fix: track pending connections to prevent MaxConns violations during DB recovery - #9
Open
Kasuki354 wants to merge 2 commits into
Open
fix: track pending connections to prevent MaxConns violations during DB recovery#9Kasuki354 wants to merge 2 commits into
Kasuki354 wants to merge 2 commits into
Conversation
…DB recovery The race condition occurred because inFlightConns was decremented immediately after createNewConn, before the connection was added to the pool. Under a concurrent burst, multiple goroutines could observe available slots and initiate dialing simultaneously, temporarily exceeding MaxConns. Fix: decrement inFlightConns only after the connection is fully established and added to the pool. On error, decrement immediately to free the slot. This ensures len(conns) + inFlightConns never exceeds maxConns. Resolves colmev080#3
|
😅 Unfortunately there are no rewards left to claim in this issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #3: Prevent Connection Storms and MaxConns Violations in pgxpool during DB Recovery
Root Cause
The original code decremented inFlightConns immediately after createNewConn returned, before the connection was added to p.conns. Under a concurrent burst:
Fix
Test
/claim #3