Repository navigation
fix(parse): preserve block HTML order and slot boundaries in components #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
onmax
wants to merge
1
commit into
comarkdown:main
Choose a base branch
from
onmax:fix/inline-html-in-block-components
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
84 changes: 84 additions & 0 deletions
84
packages/comark/SPEC/HTML/block+component-ordered-blocks.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| ## Input | ||
|
|
||
| ```md | ||
| ::foo | ||
| <div> | ||
|
|
||
| para | ||
|
|
||
| # Title | ||
|
|
||
| more | ||
|
|
||
| </div> | ||
| :: | ||
| ``` | ||
|
|
||
| ## AST | ||
|
|
||
| ```json | ||
| { | ||
| "frontmatter": {}, | ||
| "meta": {}, | ||
| "nodes": [ | ||
| [ | ||
| "foo", | ||
| {}, | ||
| [ | ||
| "div", | ||
| { | ||
| "$": { | ||
| "html": 1, | ||
| "block": 1 | ||
| } | ||
| }, | ||
| [ | ||
| "p", | ||
| {}, | ||
| "para" | ||
| ], | ||
| [ | ||
| "h1", | ||
| { | ||
| "id": "title" | ||
| }, | ||
| "Title" | ||
| ], | ||
| [ | ||
| "p", | ||
| {}, | ||
| "more" | ||
| ] | ||
| ] | ||
| ] | ||
| ] | ||
| } | ||
| ``` | ||
|
|
||
| ## HTML | ||
|
|
||
| ```html | ||
| <foo> | ||
| <div> | ||
| <p>para</p> | ||
| <h1 id="title">Title</h1> | ||
| <p>more</p> | ||
| </div> | ||
| </foo> | ||
| ``` | ||
|
|
||
| ## Markdown | ||
|
|
||
| ```md | ||
| ::foo | ||
| <div> | ||
| para | ||
|
|
||
|
|
||
| # Title | ||
|
|
||
|
|
||
| more | ||
| </div> | ||
| :: | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| ## Input | ||
|
|
||
| ```md | ||
| ::foo | ||
| <div> | ||
|
|
||
| default | ||
|
|
||
| #one | ||
| named | ||
| :: | ||
| ``` | ||
|
|
||
| ## AST | ||
|
|
||
| ```json | ||
| { | ||
| "frontmatter": {}, | ||
| "meta": {}, | ||
| "nodes": [ | ||
| [ | ||
| "foo", | ||
| {}, | ||
| [ | ||
| "div", | ||
| { | ||
| "$": { | ||
| "html": 1, | ||
| "block": 1 | ||
| } | ||
| }, | ||
| "default" | ||
| ], | ||
| [ | ||
| "template", | ||
| { | ||
| "name": "one" | ||
| }, | ||
| "named" | ||
| ] | ||
| ] | ||
| ] | ||
| } | ||
| ``` | ||
|
|
||
| ## HTML | ||
|
|
||
| ```html | ||
| <foo> | ||
| <div> | ||
| default | ||
| </div> | ||
| <template name="one"> | ||
| named | ||
| </template> | ||
| </foo> | ||
| ``` | ||
|
|
||
| ## Markdown | ||
|
|
||
| ```md | ||
| ::foo | ||
| <div> | ||
| default | ||
| </div> | ||
|
|
||
| #one | ||
| named | ||
| :: | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: comarkdown/comark
Length of output: 17977
Script executed:
Repository: comarkdown/comark
Length of output: 5032
Add a closing separator to block-level text-only HTML in component bodies.
In a component body, a block-level HTML element with only text children (for example
<div>Your changes have been saved.</div>) gets no closing separator.oneLineris true for it, soendsBlockis false athtml.ts:117. The following paragraph is then written directly after the closing tag. On reparse, a line that starts with a block-level HTML tag runs as raw HTML until the next blank line, so the following paragraph is no longer parsed as Markdown.Decide the separator from block status, not from whether the output fits on one line. Keep inline one-liners (
$.block === 0) and children of HTML-mode parents on their current behavior.Suggested fix
Committable suggestion