Skip to content

chore(deps): update entities to v9 - #545

Closed
onmax wants to merge 1 commit into
comarkdown:mainfrom
onmax:chore/entities-9
Closed

onmax wants to merge 1 commit into
comarkdown:mainfrom
onmax:chore/entities-9

Conversation

@onmax

@onmax onmax commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

What

this updates entities from ^8.1.0 to ^9.0.0, the version markdown-exit moves to in serkodev/markdown-exit#37.

Why

because markdown-exit and Comark depend on different entities majors, every Comark bundle carries two copies of the HTML entity decode table. the tables are packed trie strings that gzip barely shrinks, so the two copies are about 35 KiB of the 93 KiB gzip for createMarkdownParser + renderMarkdown. once #37 lands, matching ^9 lets both packages share one table, cutting that bundle to 68 KiB gzip (−27%). this PR alone saves 2 KiB, because v9's table is smaller than v8's.

markdown-exit / Comark entities KiB minified / gzip
7 / 8 (today) 213.7 / 93.3
7 / 9 (this PR) 220.4 / 91.1
9 / 8 (#37 only) 205.5 / 83.5
9 / 9 (both) 182.1 / 67.9

esbuild 0.28, minified ESM, gzip -9. decodeHTML and decodeHTMLStrict keep the same API in v9.

Summary by CodeRabbit

  • Chores
    • Updated the workspace’s entity package compatibility range to version 9. This is an internal maintenance update; no user-facing changes are included in this release.

markdown-exit moves to entities ^9 in serkodev/markdown-exit#37. Comark
pins ^8, so its bundle would still carry two copies of the HTML entity
decode table. Matching ^9 lets both resolve to one copy.
@onmax
onmax requested a review from farnabaz as a code owner November 2, 2026 11:49
@coldtea-pr-lens

Copy link
Copy Markdown

Note

The title starts with chore(deps):, so PR Lens left this pull request undrawn. Comment @pr-lens draw to draw it

github.comment.notice: false in .github/pr-lens.yml turns this note off

@vercel

vercel Bot commented Nov 2, 2026

Copy link
Copy Markdown

@onmax is attempting to deploy a commit to the NuxtLabs Team on Vercel.

A member of the Team first needs to authorize it.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T11:51:59.904709Z 4ccc28a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fb4082ce-b0fd-4c3d-a25b-abee0d43960a
Commits

Reviewing files that changed from the base of the PR and between 41409df and 4ccc28a.

Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 1
  • pnpm-workspace.yaml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The workspace catalog now requires entities version ^9.0.0 instead of ^8.1.0.

Changes: Entities dependency

Layer / File(s) Summary
Update entities catalog requirement
pnpm-workspace.yaml
The workspace catalog requirement for entities changes from ^8.1.0 to ^9.0.0.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related issues

Possibly related PRs

Suggested reviewers: farnabaz

Merge Risk: Minimal · up to 4ccc2

No actionable merge-blocking risk is identified in this dependency update.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: updating the workspace dependency on entities to version 9.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pkg-pr-new

pkg-pr-new Bot commented Nov 2, 2026

Copy link
Copy Markdown

Open in StackBlitz

comark

npm i https://pkg.pr.new/comark@545

@comark/angular

npm i https://pkg.pr.new/@comark/angular@545

@comark/ansi

npm i https://pkg.pr.new/@comark/ansi@545

@comark/html

npm i https://pkg.pr.new/@comark/html@545

@comark/nuxt

npm i https://pkg.pr.new/@comark/nuxt@545

@comark/react

npm i https://pkg.pr.new/@comark/react@545

@comark/svelte

npm i https://pkg.pr.new/@comark/svelte@545

@comark/vue

npm i https://pkg.pr.new/@comark/vue@545

commit: 4ccc28a

@codspeed

codspeed Bot commented Nov 2, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 2 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 41 untouched benchmarks


Comparing onmax:chore/entities-9 (4ccc28a) with main (41409df)

Open in CodSpeed

@farnabaz

farnabaz commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR @onmax
I'm waiting for upstream maintainer to respond. hopefully markdown-exits still receives some love from the maintainer 🤞

@farnabaz

farnabaz commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

Closing in favor of #549, which moves to markdown-exit 2.1 and drops entities entirely, so the bundle ends up with a single entity table without this bump. Thanks @onmax for the bundle-size breakdown here, it made the case clearly!

@farnabaz farnabaz closed this Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants