Repository navigation
Conversation
markdown-exit moves to entities ^9 in serkodev/markdown-exit#37. Comark pins ^8, so its bundle would still carry two copies of the HTML entity decode table. Matching ^9 lets both resolve to one copy.
|
Note The title starts with
|
|
@onmax is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update entities catalog requirement pnpm-workspace.yaml |
The workspace catalog requirement for entities changes from ^8.1.0 to ^9.0.0. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Possibly related issues
- comarkdown/comark#404 describes this same
entitiesversion update.
Possibly related PRs
- comarkdown/comark#511 changes the same workspace catalog entry to another
entitiesversion.
Suggested reviewers: farnabaz
Merge Risk: 
Minimal · up to 4ccc2
-
No actionable merge-blocking risk is identified in this dependency update.
Pre-merge checks: 
4
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
comark
@comark/angular
@comark/ansi
@comark/html
@comark/nuxt
@comark/react
@comark/svelte
@comark/vue
commit: |
Merging this PR will not alter performance1 warning
Comparing |
|
Thanks for the PR @onmax |
What
this updates
entitiesfrom^8.1.0to^9.0.0, the version markdown-exit moves to in serkodev/markdown-exit#37.Why
because markdown-exit and Comark depend on different
entitiesmajors, every Comark bundle carries two copies of the HTML entity decode table. the tables are packed trie strings that gzip barely shrinks, so the two copies are about 35 KiB of the 93 KiB gzip forcreateMarkdownParser+renderMarkdown. once #37 lands, matching^9lets both packages share one table, cutting that bundle to 68 KiB gzip (−27%). this PR alone saves 2 KiB, because v9's table is smaller than v8's.entitiesesbuild 0.28, minified ESM, gzip -9.
decodeHTMLanddecodeHTMLStrictkeep the same API in v9.Summary by CodeRabbit