Repository navigation
fix: add {.x} to an existing class instead of replacing it
#585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
09ac893
fix: add `{.x}` to an element's existing class instead of replacing it
ampagent c1abc23
fix: add `{.x}` to the class of plugin-emitted inline components
ampagent 5ede43d
fix: keep inline component attributes on a plain object
ampagent 680a212
Merge branch 'main' into fix/attribute-class-merge
farnabaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mdc_inline_componentmerge still overwrites the element classmdc_inline_componentintree.tsbuilds its node with{ ...tokenAttrs, ...attrs }, so a plugin that emits an inline component token carryingclassand then a user{.x}replaces the class instead of joining it, the exact bug this change fixes for every other token path.Fix: Apply the same class join in the
mdc_inline_componentprocessor: mergetokenAttrsandattrssoclassis appended, or route it throughprocessPossibleAttributesSyntax.🤖 Prompt for AI agents
✅ Addressed in c1abc23