Repository navigation
Add a setup page to the web interface - #26
Merged
Merged
Conversation
A new Setup page shows what to enter in Sonarr and Radarr: the download client's host, port and category, and each site's indexer URL, the API path and the categories for each app. The addresses are the ones the page was opened with, behind a reverse proxy too, and Use SSL appears only over HTTPS. The API key is named, not shown. A click selects a value whole, since the clipboard API is not available over plain HTTP. The page also lists each site as working, with the time of its last download, or unreachable, with the error, the next attempt and the downloads waiting, and shows the version, the download folder and the download categories. newznab exports BaseURL and Categories so the page and the API agree, and Job.Unreachable tells a job held back by its provider's outage from one with an error of its own. Four tabs with their counts no longer fit beside a page's control on a phone, so there the tabs take the row, scroll if they are still too wide, and the control goes under them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Setup page to the web interface, so connecting Sonarr and Radarr no longer means assembling the values from the docs.
The addresses are the ones the page was opened with, honouring
X-Forwarded-ProtoandX-Forwarded-Hostas the Newznab API does; a note says to use another host if the apps reach magnetowid differently. The API key is named, not shown. A click selects a value whole: there are no copy buttons, because the clipboard API is not available over plain HTTP, and so no new script.newznabexportsBaseURLandCategoriesso the page and the API agree.Job.Unreachabletells a job held back by its provider's outage from one with an error of its own, so the page shows the right error. Only downloads tell whether a site is reachable; nothing probes the sites.Four tabs with their counts no longer fit beside a page's control on a phone. There the tabs now take the row and scroll if they are still too wide, and the queue's Pause button goes under them, on the right.
Tested:
make test; screenshots in Chromium of the page in light and dark at desktop and phone widths, including the unreachable state from a rendered sample and custom categories behind HTTPS; a Playwright check that a selected value stays selected through the page's refreshes; tab bar widths measured from 320 to 400 px with two- and three-digit counts; the queue page on a phone; the real binary by hand; Codex review.