Feature/functional coverage tests - #115
Merged
Merged
Conversation
Rewrite tests/Support/Fixture/router.php for maintainability (named helpers, sectioned routes, header comment explaining the fixture's purpose) with identical behaviour - all fixture tests still pass. Remove FixtureTransportCest::sendsCloudflareAccessHeaders and its $_ENV unset in _after(): it mutated process-global $_ENV to force the APPLICATION_ENV=sdk-github branch, which leaked across suites and broke HelpersCest's env read. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Drop the fixture API server (IntegrationApi + router.php) that booted a real php -S process to return canned Comgate responses. Each functional test now drives Client/ClientTerminal through a small FakeTransport double that queues its own responses and records what the SDK sent. - Add tests/Support/FakeTransport.php (ITransport double) - Rewrite the fixture Cests as *FunctionalCest using per-test mocks - MOTO test owns its RSA key pair and decrypts what the SDK sent - Remove the transport-level and download-subprocess tests that could not be meaningfully mocked Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.