-
Notifications
You must be signed in to change notification settings - Fork 37
USF-3972: Order backwards incompatibilities #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release
Are you sure you want to change the base?
Changes from all commits
7cebf37
65d9594
37e2439
b97958a
8724e01
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -671,7 +671,17 @@ import Link from '@components/Link.astro'; | |
| - **Login as Customer**: Added Login as Customer feature support ([#248](https://github.com/magento-commerce/storefront-compatibility/pull/248)). | ||
|
|
||
| **v4.7.12** | ||
| - **Guest order cancel with comments**: Resolved an internal server error when calling `requestGuestOrderCancel` on orders that include order comments. The error was introduced when the Order drop-in added `OrderComments` support and the new `comments` field appeared in order responses; the SCP `requestGuestOrderCancel` mutation did not handle the presence of that field, causing a 500 error on cancel requests ([#275](https://github.com/magento-commerce/storefront-compatibility/pull/275)). | ||
| - **Guest order cancel with comments**: Resolved an internal server error when calling `requestGuestOrderCancel` on orders that include order comments. The cancellation flow was writing status history entries without an explicit UTC `created_at` timestamp; when the Order drop-in requested `comments { message timestamp }`, the null timestamp caused the GraphQL resolver to return a 500 error. This fix is required for a safe Order drop-in v3.3.0 upgrade on Adobe Commerce 2.4.7 deployments. See the [April 2026 suite notes](/releases/) for the full context ([#275](https://github.com/magento-commerce/storefront-compatibility/pull/275)). | ||
| </ChangelogEntry> | ||
|
|
||
| <ChangelogEntry | ||
| date="2026-04-13" | ||
| title="Storefront Compatibility Package v4.8.18" | ||
| components={['Storefront Compatibility Package']} | ||
| > | ||
| The Storefront Compatibility Package has been updated with the following changes. This release accompanies the Order drop-in v3.3.0 release; see the [April 2026 suite notes](/releases/) for the full context. | ||
|
|
||
| - **Guest order cancel with comments**: Resolved an internal server error when calling `requestGuestOrderCancel` on orders that include order comments. The cancellation flow was writing status history entries without an explicit UTC `created_at` timestamp; when the Order drop-in requested `comments { message timestamp }`, the null timestamp caused the GraphQL resolver to return a 500 error. Upgrading the Order drop-in to v3.3.0 without this SCP version causes guest cancellation to fail on Adobe Commerce 2.4.8 deployments ([#268](https://github.com/magento-commerce/storefront-compatibility/pull/268)). | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we remove the PR link from here as well?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The PR links are there because management wanted to make them available, even thought they are private. I'm not sure why anymore, but for now, I'll leave them. |
||
| </ChangelogEntry> | ||
|
|
||
| <ChangelogEntry | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdenham There are some mismatches in the release dates, and different versions appear to be grouped together. Additionally, PR links are exposed, as shown in the shared screenshot. We already addressed this issue with the following PR:
https://github.com/commerce-docs/microsite-commerce-storefront/pull/843/changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will revert this change.