Add ScatterWorkflowStep and LoopWorkflowStep#371
Merged
Conversation
To prepare the library for the new `ScatterWorkflowStep` and `LoopWorkflowStep` objects introduced in CWL v1.3, this commit adds type aliases to be used in previous CWL versions. The `ScatterWorkflowStep` is an alias for `WorkflowStep` in CWL up to v1.2, as the `WorkflowStep` object has the `scatter` and `scatterMethod` properties. The `LoopWorkflowStep` does not exist before CWL 1.3. Therefore, a `NoType` abstract class has been introduced as a placeholder.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
==========================================
+ Coverage 34.55% 34.56% +0.01%
==========================================
Files 30 30
Lines 35375 35382 +7
Branches 9555 9555
==========================================
+ Hits 12224 12231 +7
Misses 20266 20266
Partials 2885 2885 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prepare the library for the new
ScatterWorkflowStepandLoopWorkflowStepobjects introduced in CWL v1.3, this commit adds type aliases to be used in previous CWL versions.The
ScatterWorkflowStepis an alias forWorkflowStepin CWL up to v1.2, as theWorkflowStepobject has thescatterandscatterMethodproperties.The
LoopWorkflowStepdoes not exist before CWL 1.3. Therefore, aNoTypeabstract class has been introduced as a placeholder.