fix: export types, add .js to imports for nodenext compatibility#52
fix: export types, add .js to imports for nodenext compatibility#52Gregoor merged 2 commits intocommonbaseapp:mainfrom
Conversation
|
@Gregoor This would be nice to have reviewed if you have some time since the use of |
Gregoor
left a comment
There was a problem hiding this comment.
Huh, I always thought it's better to export fewer types since changing types would be API breakage (aka major version bump) but I suppose it's not as simple as I believed. Let's do it!
|
Hi, I'm not sure if you have completed the full release process yet (including npm), but I noticed the new release 0.20.1 on GitHub is well behind the latest published version number 4.0.0 per https://www.npmjs.com/package/zodex?activeTab=versions . (I also don't see 0.20.1 on npm.) |
|
yeah I was also surprised to see the github releases going, but our auto publish to NPM is still not fixed, so I'll manually do a 4.0.1 release |
I think anyone going into internal types will expect breakage so it's not a big deal. Thanks for taking care of this |
this exports types needed to get into the internals properly, and adds .js extensions to imports so they are nodenext compatible. without them, installing this into an eg. sveltekit project will have type errors in the ide