-
-
Notifications
You must be signed in to change notification settings - Fork 0
Mff updates #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Arbyhisenaj
wants to merge
25
commits into
main
Choose a base branch
from
mff-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mff updates #343
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
c03e363
cp4-icon layers (requires back-end work)
Arbyhisenaj d6c40b3
cp5-add/remove marker layers
Arbyhisenaj 07b3b22
greyed instead of hidden layers on hexmap
Arbyhisenaj 20f7edd
checkpoint
Arbyhisenaj 71895f0
checkpoint
Arbyhisenaj e2fa6fa
refactor
Arbyhisenaj f7c8299
optimised experience/UI
Arbyhisenaj e621640
removed charts
Arbyhisenaj 79d15f7
Merge branch 'main' into mff-updates
Arbyhisenaj 6ba26d5
latest
Arbyhisenaj 8f52548
latest from work
Arbyhisenaj 47656d4
save inspector settings as default
Arbyhisenaj 99056ce
Update src/app/map/[id]/components/inspector/InspectorSettingsModal/S…
joaquimds 5a02ba4
Update src/app/map/[id]/components/inspector/InspectorSettingsModal/C…
joaquimds 9674f4e
Update src/app/map/[id]/components/inspector/InspectorSettingsModal/C…
joaquimds 50337d7
Merge branch 'main' into mff-updates
joaquimds bc61ac2
optimising UX
Arbyhisenaj 8bfb914
Merge branch 'mff-updates' of https://github.com/commonknowledge/ts-m…
Arbyhisenaj d5514c4
merge/lint fixes
Arbyhisenaj 01faacc
Merge branch 'sidebar-updated-ui' into mff-updates
Arbyhisenaj b629070
updated sidebar
Arbyhisenaj 1d041b6
chore: fix lint
joaquimds a283744
work laptop checkpoint
Arbyhisenaj ffa1dce
dang - forgot to push
Arbyhisenaj 7755f56
optimisation
Arbyhisenaj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
migrations/1772020000000_data_source_default_inspector_config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | ||
| import { sql } from "kysely"; | ||
| import type { Kysely } from "kysely"; | ||
|
|
||
| export async function up(db: Kysely<any>): Promise<void> { | ||
| await sql` | ||
| ALTER TABLE "data_source" | ||
| ADD COLUMN "default_inspector_config" jsonb DEFAULT NULL | ||
| `.execute(db); | ||
| } | ||
|
|
||
| export async function down(db: Kysely<any>): Promise<void> { | ||
| await sql` | ||
| ALTER TABLE "data_source" | ||
| DROP COLUMN "default_inspector_config" | ||
| `.execute(db); | ||
| } | ||
18 changes: 18 additions & 0 deletions
18
migrations/1772030000000_data_source_default_inspector_config_updated_at.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | ||
| import type { Kysely } from "kysely"; | ||
|
|
||
| export async function up(db: Kysely<any>): Promise<void> { | ||
| await db.schema | ||
| .alterTable("dataSource") | ||
| .addColumn("defaultInspectorConfigUpdatedAt", "timestamptz", (col) => | ||
| col.defaultTo(null), | ||
| ) | ||
| .execute(); | ||
| } | ||
|
|
||
| export async function down(db: Kysely<any>): Promise<void> { | ||
| await db.schema | ||
| .alterTable("dataSource") | ||
| .dropColumn("defaultInspectorConfigUpdatedAt") | ||
| .execute(); | ||
| } |
17 changes: 17 additions & 0 deletions
17
migrations/1772203924531_data_source_default_inspector_config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | ||
| import { sql } from "kysely"; | ||
| import type { Kysely } from "kysely"; | ||
|
|
||
| export async function up(db: Kysely<any>): Promise<void> { | ||
| await sql` | ||
| ALTER TABLE "data_source" | ||
| ADD COLUMN "default_inspector_config" jsonb DEFAULT NULL | ||
| `.execute(db); | ||
| } | ||
|
|
||
| export async function down(db: Kysely<any>): Promise<void> { | ||
| await sql` | ||
| ALTER TABLE "data_source" | ||
| DROP COLUMN "default_inspector_config" | ||
| `.execute(db); | ||
| } |
18 changes: 18 additions & 0 deletions
18
migrations/1772203924532_data_source_default_inspector_config_updated_at.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | ||
| import type { Kysely } from "kysely"; | ||
|
|
||
| export async function up(db: Kysely<any>): Promise<void> { | ||
| await db.schema | ||
| .alterTable("dataSource") | ||
| .addColumn("defaultInspectorConfigUpdatedAt", "timestamptz", (col) => | ||
| col.defaultTo(null), | ||
| ) | ||
| .execute(); | ||
| } | ||
|
|
||
| export async function down(db: Kysely<any>): Promise<void> { | ||
| await db.schema | ||
| .alterTable("dataSource") | ||
| .dropColumn("defaultInspectorConfigUpdatedAt") | ||
| .execute(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration style inconsistency: Migration 1772020000000 uses raw SQL with snake_case table name, while migration 1772030000000 uses Kysely schema builder with camelCase. For consistency and to match the pattern in migration 1770912056401_data_source_record_count.ts (which adds columns using schema builder then updates with raw SQL), consider using Kysely's schema builder for both or keeping the same style. This is a minor inconsistency but could confuse future developers.