Conversation
spyridon97
force-pushed
the
add-parallel-coordinates-chart
branch
3 times, most recently
from
4b038b2 to
9fdf2f8
Compare
lassoan
left a comment
lassoan
left a comment
There was a problem hiding this comment.
I added a few nitpicks, but overall it looks good. I just miss a test (that could also serve as an example) of how to use the new chart type.
| // add transfer function item | ||
| vtkPlot* ctfPlot = view.addColorTransferFunction(ctf); | ||
| view.chart()->SetPlotCorner(ctfPlot, 1); | ||
| view.xyChart()->SetPlotCorner(ctfPlot, 1); |
There was a problem hiding this comment.
Why is it called xyChart and not chartXY? If we follow VTK naming conventions then the method name should be chartXY.
There was a problem hiding this comment.
I was thinking that it is more natual to say, parallel coordinates chart, instead of chart parallel coordinates. Plus it matches the naming convention of abstractChart().
vtk in general follows the following naming pattern. vtk(Abstract)Base, vtkSpecialBase, e.g. vtkAlgorithm, vtkPolyDataAlgorithm. vtkCharts* are kinda the exception to the rule.
There was a problem hiding this comment.
I agree that having xyChart may feel more natural and is aligned with the convention adopted by Qt in the Qt Chart1 module.
That said, CTK provides a convenience wrapper around VTK, for sake of consistency with the VTK naming convention, I think we should then have the set/get functions and associated internal variables match the VTK class names.
ls -1 vtkCh*
vtkChartBox.cxx
vtkChartBox.h
vtkChart.cxx
vtkChart.h
vtkChartHistogram2D.cxx
vtkChartHistogram2D.h
vtkChartLegend.cxx
vtkChartLegend.h
vtkChartMatrix.cxx
vtkChartMatrix.h
vtkChartParallelCoordinates.cxx
vtkChartParallelCoordinates.h
vtkChartPie.cxx
vtkChartPie.h
vtkChartXY.cxx
vtkChartXY.h
vtkChartXYZ.cxx
vtkChartXYZ.h
Footnotes
| switch (corner) | ||
| { | ||
| // bottom left | ||
| case 0: |
There was a problem hiding this comment.
Aren't there enums for 0, 1, 2, 3?
There was a problem hiding this comment.
Parallel coordinates don't have plot corner function.
spyridon97
force-pushed
the
add-parallel-coordinates-chart
branch
5 times, most recently
from
cb71d40 to
1cb4ffa
Compare
jcfr
force-pushed
the
add-parallel-coordinates-chart
branch
2 times, most recently
from
69fca16 to
5ea5ad3
Compare
|
|
||
| // ---------------------------------------------------------------------------- | ||
| vtkChartXY* ctkVTKChartView::chart()const | ||
| { |
There was a problem hiding this comment.
| { | |
| { | |
| qWarning() << "This function is deprecated. Use xyChart() or abstractChart() instead"; |
| Q_ENUM(ChartTypes) | ||
|
|
||
| /// Set/Get the type of the chart, XYChart is the default | ||
| /// The string names as the same as the ChartTypes enum |
There was a problem hiding this comment.
| /// The string names as the same as the ChartTypes enum |
Looks this description is not correct.
|
Once this last few comments have been addressed, this will be good to integrate. |
jcfr
force-pushed
the
add-parallel-coordinates-chart
branch
from
5ea5ad3 to
b2c412b
Compare
jcfr
force-pushed
the
add-parallel-coordinates-chart
branch
from
b2c412b to
263d17f
Compare
Introduces abstractChart() and chartXY() functions. The chart() function has been converted to chartXY(). Therefore, chart() is deprecated. Co-authored-by: Andras Lasso <lasso@queensu.ca> Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
jcfr
force-pushed
the
add-parallel-coordinates-chart
branch
from
263d17f to
0c80e70
Compare
3 participants
This Pull request adds support for changing the chart type from vtkChartXY to vtkChartParallelCoordinates.
@lassoan @jcfr