feat: wrap layer children in Placed for inline placement#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the
(Vec2, Box<dyn _>)tuple in layer children with aPlaced<C>wrapper, and add ext traits so positioning becomes a method chain on the component itself. Layer construction can now be a single struct-literal expression with all children placed inline.tellur-core::placement(new):Placed<C: ?Sized> { position, child }, plusVectorPlacement/RasterPlacementext traits providingat(pos)andanchored(self_anchor).snap_to(target_point). The anchored form mirrorsVec2::anchored(...).snap_to(...)so the geometry vocabulary carries over to component placement.tellur-core::layer:VectorLayer.children/Layer.childrennow holdVec<Placed<dyn _>>;addtakes a singlePlaced<dyn _>argument.tellur-core::geometry: renameVec2::anchor→anchored(past-participle reads better at call sites). DropAnchoredSize::snap_to_anchor— callers usesnap_to(target_anchor.point(target_size)).timeline_to_mp4also unrolls the fps loop into four direct entries. The(view_box().anchor().snap_to_anchor(...), boxed())tuple form is gone.