Skip to content

Conversation

@VatsalSy
Copy link
Member

@VatsalSy VatsalSy commented Feb 7, 2026

Summary

  • Avoid attempting a commit/push when the search database was not cloned or copied

Changes Made

  • Guard the update-search workflow to exit early if assets/js/search_db.json is missing

Testing

  • Not run (workflow change only)

Copilot AI review requested due to automatic review settings February 7, 2026 03:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Guards the update-search GitHub Actions workflow so it won’t attempt to commit/push when the search database artifact isn’t present, avoiding unnecessary git operations when the search repo wasn’t available.

Changes:

  • Add an early-exit check in the “Commit and push changes” step when assets/js/search_db.json is missing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 7, 2026

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Enhanced automated build pipeline reliability with improved error handling to prevent failed operations when expected resources are unavailable.

Walkthrough

A GitHub Actions workflow was modified to add a conditional guard that skips committing and pushing changes when the search_db.json file is missing, preventing attempted git operations on non-existent files.

Changes

Cohort / File(s) Summary
Workflow Guard Condition
.github/workflows/update-search.yml
Added conditional check in the "Commit and push changes" step to skip git operations when assets/js/search_db.json is missing, improving error handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A guard now stands with watchful eye,
Before the files take to the sky,
"Does search_db.json exist?" it cries,
No phantom pushes—just truth and ties! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a guard to skip search updates when the database file is missing, which aligns with the workflow modification in the changeset.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose (avoiding commit/push when search database is missing) and the change made (guarding the workflow to exit early).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-search-workflow-missing-db

Comment @coderabbitai help to get the list of available commands and usage tips.

@VatsalSy VatsalSy merged commit fa87476 into main Feb 7, 2026
9 checks passed
@VatsalSy VatsalSy deleted the fix-search-workflow-missing-db branch February 8, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant