fix(navigate): support back/forward history + Windows pipe in drive.mjs (v2.2.1) - #17
Merged
Merged
Conversation
browser_navigate treated url back as a relative URL and landed on chrome-extension://<id>/back, stranding the tab on a protected page. It now walks the tab history via chrome.tabs.goBack/goForward and reports the URL it actually landed on. scripts/drive.mjs connected to ~/.browser-controller/daemon.sock on every platform; on Windows the daemon listens on the named pipe \\.\pipe\browser-controller (daemon-config.ts), so it always failed with ENOENT. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes found while driving the stack from an agent on Windows:
1. now supports / (extension/handlers/navigation.js)
Previously the history keywords were treated as relative URLs — resolved to , stranding the tab on a protected page with no way back for the agent.
2. works on Windows
The helper hard-coded the unix socket on every platform; on Windows the daemon listens on the named pipe (daemon-config.ts), so it always failed with ENOENT. It now picks the correct transport per platform.
Test plan
Did you mean this?
npm test # Test a package
To see a list of supported npm commands, run:
npm help — 275 passing (daemon IPC suite is environmental-only on Windows while a live daemon owns the fixed named pipe)