Repository navigation
Check CI for private machine, person, and agent names - #10
Merged
Merged
Conversation
Public repositories hold invented examples only: no machine or host names, no personal home paths, no real person IDs, and no internal agent or mission IDs. scripts/check-private-names.py enforces that on every pull request and push to main, and --self-test proves it still catches each kind. It is the same script as in pty, pty-relay, pty-layout and transplant. This repository passes it as it stands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
scripts/check-private-names.pyand aPrivate namesworkflow, the same check pty, pty-relay, pty-layout and transplant run. It fails on the fleet's machine names (stored as SHA-256 digests),/home/USERand/Users/USERpaths other thanexample, realperson/IDs, andagent/fleet/,mission/fleet/ormission-run/fleet/IDs.--self-testproves it still catches each kind. Lines that must stay go in.private-names-allow.This repository passes it as it stands, so the PR adds only the check.