This repository was archived by the owner on Sep 29, 2026. It is now read-only.
Repository navigation
Replace private machine names and check CI for them - #81
Merged
Merged
Conversation
The st2-network and st2-doctor-structure cells used a real machine as their fixture host; they now use evalhost, the invented host the other cells already use, including the fixture's net/evalhost directory. Two judge comments and four fixture reflog lines named the same machine. scripts/check-private-names.py, the same check as in pty, pty-relay, pty-layout and transplant, now runs on every pull request with a self-test that proves it still catches each kind of name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public repositories hold invented examples only. Running
scripts/check-private-names.py(the check pty, pty-relay, pty-layout and transplant run) over this repository found 22 lines naming a real machine:cells/st2-networkandcells/st2-doctor-structureused it as the fixture's st2 host (--host,host,ST_AGENT, the judges' expected output, and thefixture/net/<host>/directory). They now useevalhost, the invented host other cells already use.judges/coordination.shcomments used it as an example prefix.poisoned-prfixture reflog lines carried it in the committer address. The fixture commits themselves were already invented.The PR also adds the check and a
Private namesworkflow. The repository is archived again once this merges.