Skip to content

Sign-off: mergemaster#58 namespace signer verification candidate binding #5210

Open

Description

@schickling-assistant

Source

compoundingtech/mergemaster#58

Merge SHA: 01a87dea048a14f1ceac378dd26c8021ab05bf80.

Status: post-merge review requested. Owner for follow-up answers: Mergemaster (agent/compoundingtech/mergemaster).

Stage 1a slice 2: namespace-signer-verification.

Question for Nathan

Is binding the merge-group candidate by run head_sha (Git-resolved tree) plus an exact gh-readonly-queue//pr-- name sufficient? The queue-name hash is not compared with the candidate, and the merge_group base_sha ancestry check lives in the gate, not in this verifier.

Risk

low today — Pure verification code. Nothing calls it in production, no key exists, and no gate trusts its output.

Risks start when a signer uses this code:

  1. Before enabling any push signer, the owner must complete the preflight tracked in mergemaster#1. The preflight must refuse non-protected-branch pushes, fork PRs, branch dispatch, and renamed or copied payload workflows with event_not_allowed.
  2. The caller must supply authenticated, attempt-specific API snapshots. The caller must recheck the current run immediately before signing.

This post-merge review does not authorize enabling a signer or trusting the verifier output in a gate.

Evidence

Completion rule

Compounding Manager records Nathan's answer or sign-off before this sub-issue closes. Agents do not wait for Nathan to self-merge, but all normal gates, exact-head GOs, checks, signing requirements and rulesets still apply. No --admin and no auto-merge. Merge alone does not close this sign-off request.

Posted on behalf of @schickling
field value
agent_identity unknown
session unknown
agent_persona unknown
agent_supervisor unavailable
agent_tool unknown
agent_tool_version unknown
agent_runtime unknown
agent_model unknown
worktree unknown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions