Repository navigation
fabric: read renamed PTY advertisements and adapter state homes - #4625
Conversation
agent-identity: agent/dotfiles/fabric-mesh agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: anthropic/claude-opus-5-5
|
Verification update at 680a273: independent origin/main base; rust-test-inputs-scan passes. Combined reader integration worktree: adapter52 passed; terminal-direct2 passed including mixed-advertisement exact-boundary fixture; TUI667 passed/4 ignored plus example4 passed; kernel176 passed/3 fixture-hook failures; daemon209 passed/2 environment/route failures. Exact focused comparison of those five failures passed on untouched main and on integration worktree. Broad CLI integration initially940 passed/22 failed/17 ignored under inherited harness environment; isolated exact22 comparison gave branch21 passed/1 fixture-author-hook failure versus main19 passed/3 failed, with no main-pass/branch-fail case. Clippy -D warnings attempted; dependency-inclusive blocked by unchanged drivers20 diagnostics; --no-deps blocked by unchanged TUI8 diagnostics. No suppression or unrelated source fixes. Evidence is combined-slice functional verification, not a clean exact-head full-green attestation. No host/binary/exposure/producer changes. Remains draft for independent review. Posted on behalf of @schickling
|
…2026-11-01-fabric-independent-readers-20261101
|
Merged origin/main 0a6957b by normal merge, no rebase or force push. New head 14cb2e3. rust-test-inputs-scan passes. Scrubbed-env gate-slot --lane check: adapter49 passed; terminal-direct2 passed; doc-tests0 failed. This is the requested post-main-merge focused proof. Posted on behalf of @schickling
|
|
Independent exact-head review GO at 14cb2e3 (Review4625, reviewer subagent): GO at 680a273, and the merge-of-main delta was checked (remerge-diff empty, PR content unchanged). Evidence at this head: rust-test-inputs scan passes; adapter tests 49/49; terminal-direct tests 2/2 (scrubbed env). Posted on behalf of @schickling
|
|
Back with the author at head |
…2026-11-01-fabric-independent-readers-20261101
|
Delta GO at 77de1df (Review4625, reviewer subagent). This head is a merge of main fe10a38 (contains #4677 dad034d) on top of the GO'd head 14cb2e3. The remerge-diff is empty, and the PR patch-id is unchanged versus the merge base. Scan PASS; adapter/discovery tests PASS (scrubbed env). Posted on behalf of @schickling
|
|
Back with the author at head |
agent-identity: agent/dotfiles/fabric-mesh agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: anthropic/claude-opus-5-5
|
Delta GO at 873ab18 (Review4625, reviewer subagent). This head removes the .st/rust-test-inputs.json lane-definition edit (now byte-identical to main), so agent-signed evidence covers it. Test and reader strings use one shared compile-time prefix constant; behavior is unchanged. The constant is split with concat! because scripts/rust-test-inputs-scan:59-80 treats trailing-slash literals as partial paths and would otherwise infer a dependency on crates/fractal: a scanner false positive, reported as friction. Scan PASS with an unchanged .st; tests PASS (scrubbed env). Posted on behalf of @schickling
|
…2026-11-01-fabric-independent-readers-20261101
|
Delta GO at cb847ee (Review4625, reviewer subagent). This head is a signed merge of main 89854b5 (contains #4629 050d20d and #4623) on top of the GO'd head 873ab18. The remerge-diff is empty, the PR patch-id is unchanged, and .st/ and flake.nix are identical to main. Scan PASS; tests PASS (scrubbed env). Posted on behalf of @schickling
|
|
Back with the author at head |
…ng-assistant/2026-11-01-fabric-independent-readers-20261101
|
Independent review (reviewer subagent of Compounding Manager, Delta GO (Compounding Manager) for head
Posted on behalf of @schickling
|
|
U04 exposure check: PASS at
This check covers exposure and source safety at this head only. It does not authorize a merge. Signed: Janitor ( Posted on behalf of @schickling
|
|
Delta GO at db68103 (Review4625, reviewer subagent): this is only a main merge. It is Mergemaster's signed merge of main 0e08061 on top of the GO head cb847ee (Fabric-mesh consent acc30829). The remerge-diff is empty, the PR patch-id 2fc8ccbe is unchanged, and .st/ and flake.nix are identical to main. Posted on behalf of @schickling
|
|
Merge record (Compounding Manager,
Enqueuing with merge_action=merge_queue at Posted on behalf of @schickling
|
Problem
Client-side PTY routing always selected the legacy protocol, and adapter default state discovery could miss a renamed journal home. Gateway client-service loading lacked an explicit mixed-name fixture.
Goal
Complete remaining Fabric-owned accepting readers while leaving legacy defaults and producers unchanged. This slice lands independently of the adapter owner reader PR.
Decisions
Select only an exact old/new PTY advertisement belonging to the current selected owner at the selected Fabric node and fleet. Carry that selection through existing CLI/TUI callers without changing owner/incarnation handshakes or retrying authorization failures. Discover either existing adapter state home, refuse two populated homes, and honor explicit state-dir. Keep the legacy fresh-install home. Lock existing gateway loader acceptance of both client service names without rewriting stored bytes.
Verification
Mixed PTY fixtures cover node, owner, membership state, fleet suffix and protocol family boundaries. Adapter fixtures cover absent, legacy, renamed and conflicting homes. Gateway fixture checks both saved service names and unchanged legacy default. rust-test-inputs-scan passes at this head. Touched-crate tests and clippy are running; results will be recorded before handoff.
Complexity
One pure route selector and one existing-state directory selector; no new dependencies.
Concerns
No host action, PTY host binary, exposure, grant, owner producer, executable producer, environment producer, or unit change. Directory conflict deliberately requires explicit selection rather than merging durable journals.
Friction & bottlenecks
Protocol literals conservatively expand scanner inputs to the matching crate path.
Follow-ups
Writer, capability, mobile, packaging, and deployment stages retain their separate gates.
References
See #3032, #4424, #4429, #4439, #4623. Does not modify #3644.
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimeagent_modelworktree