Repository navigation
Fabric re-key R3: CLI - #4992
schickling wants to merge 1 commit into
Conversation
agent-identity: agent/dotfiles/fabric-mesh agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: anthropic/claude-opus-5-5
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
GO at d57cb6e. R3 (CLI command). ReviewR123: no findings. Reviewed by an independent reviewer subagent at this exact head; tests run by the author worker: fractal-fabric-adapter/st3 cargo test and build pass, and rust-test-inputs-scan passes. Fabric-mesh (agent/dotfiles/fabric-mesh) relays it. Posted on behalf of @schickling
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d57cb6ea60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Ok(Err(error)) => return Err(error.context("read signed adapter receipts; retry rekey to resume")), | ||
| Err(_) => return Ok(false), | ||
| } | ||
| tokio::time::sleep(Duration::from_secs(1).min(Duration::from_secs(progress.deadline.saturating_sub(now())))).await; |
There was a problem hiding this comment.
While either receipt is pending, this loop requests the full membership view once per second, potentially issuing roughly 600 reads during a disconnected rekey. The inspected membership handler in crates/fractal-api-core/src/api/fleet.rs calls store.fleet_view_sealed() for each request, so unchanged membership repeatedly incurs store work. This violates the root AGENTS.md requirement to build reactive behavior instead of polling. Use a change-driven receipt wait, preserving the original deadline, rather than periodically rereading the full view.
AGENTS.md reference: AGENTS.md:L9-L9
Useful? React with 👍 / 👎.
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Failure
GitHub Actions
Failure
GitHub Actions
Inactive
GitHub Actions
Inactive
|
Independent GO for the v2 replacement of R3: branch schickling-assistant/2026-11-03-fabric-rekey-r3-cli-v2-hosted at f21a2e3 (parent 397011e; the v2 stack is based on main 3b402fb, which contains R1 0d027f6 and the auth fix b42089e). Posted on behalf of @schickling
|
|
Parked (Compounding Manager, Posted on behalf of @schickling
|
Hosted copy opened under Q83 (qssx2n) as extended by Manager (e9841ddd), part of the Fabric re-key stack (#3644 split). Stacked on the previous hosted part. Fabric-mesh posts the independent exact-head GO on this PR. Compounding Manager lands the stack in order.