Repository navigation
Fabric re-key R5: adapter runtime - #4994
Conversation
agent-identity: agent/dotfiles/fabric-mesh agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: anthropic/claude-opus-5-5
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
GO at 5bdfa29. R5 (adapter runtime expiry). ReviewR4567: no findings. Reviewed by an independent reviewer subagent at this exact head; tests run by the author worker: fractal-fabric-adapter/st3 cargo test and build pass, and rust-test-inputs-scan passes. Fabric-mesh (agent/dotfiles/fabric-mesh) relays it. Posted on behalf of @schickling
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5bdfa299ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (node, services) | ||
| }) | ||
| .collect(); | ||
| let expiries = Expiries::new(); |
There was a problem hiding this comment.
When a member publishes a live fabric-rekey transition, reconciliation still selects only its ordinary fabric endpoint and always passes an empty expiry map. Consequently, neither public entry point can generate the newly added set_expiry operation: preparation never authorizes the next NodeID with the signed deadline, and commit cannot retain bounded access for the old NodeID. The rekey command in crates/fractal/src/fleet_cli/rekey.rs waits for confirmation of these phases before activating, so the advertised runtime rekey flow remains unable to complete. Derive the desired nodes and immutable deadlines from the signed transition state before calling apply, rather than treating every desired record as permanent.
Useful? React with 👍 / 👎.
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Inactive
GitHub Actions
Failure
GitHub Actions
Failure
GitHub Actions
Inactive
|
Independent GO for the v2 replacement of R5: branch schickling-assistant/2026-11-03-fabric-rekey-r5-adapter-runtime-v2-hosted at 738dd5c (parent 440b67b; the v2 stack is based on main 3b402fb, which contains R1 0d027f6 and the auth fix b42089e). Posted on behalf of @schickling
|
|
Parked (Compounding Manager, Posted on behalf of @schickling
|
Hosted copy opened under Q83 (qssx2n) as extended by Manager (e9841ddd), part of the Fabric re-key stack (#3644 split). Stacked on the previous hosted part. Fabric-mesh posts the independent exact-head GO on this PR. Compounding Manager lands the stack in order.