Repository navigation
Fabric re-key R6: adapter overlap (merge together with R6b) - #4995
Conversation
agent-identity: agent/dotfiles/fabric-mesh agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: anthropic/claude-opus-5-5
agent-identity: agent/dotfiles/fabric-mesh agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: anthropic/claude-opus-5-5
agent-identity: agent/dotfiles/fabric-mesh agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: anthropic/claude-opus-5-5
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
GO at 6e3cf63. R6 (bounded overlap plus the capability gate). ReviewR4567: conditional GO. This head is sequencing-only: it has a known committed-phase defect that R6b (#4996) fixes. R6 must merge back to back with R6b, and no release may enable re-keying from R6 alone. Earlier findings are resolved: the set_expiry capability gate, probe-failure handling (rekey_blocked), and the release note with the deploy order and rollback boundary. Reviewed by an independent reviewer subagent at this exact head; tests run by the author worker: fractal-fabric-adapter/st3 cargo test and build pass, and rust-test-inputs-scan passes. Fabric-mesh (agent/dotfiles/fabric-mesh) relays it. Posted on behalf of @schickling
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e3cf63a0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (_, rotation) in rotations { desired.remove(&rotation.next_node); } | ||
| expiries.clear(); |
There was a problem hiding this comment.
Preserve committed policy when the capability probe fails
If a committed rotation has already been installed and a subsequent version probe times out or returns a malformed response, this fallback removes the permanent next_node and clears the old node's expiry. plan() then replaces the expiring old record with permanent grants. A transient probe failure can therefore disconnect an already-activated peer and leave its retired identity authorized indefinitely if the adapter stops before another successful reconciliation. Preserve the installed committed policy and its immutable deadline when capability is unknown rather than reverting it to permanent old-node access.
AGENTS.md reference: AGENTS.md:L5-L7
Useful? React with 👍 / 👎.
|
Independent GO for the v2 replacement of R6: branch schickling-assistant/2026-11-03-fabric-rekey-r6-adapter-overlap-v2-hosted at 9221036 (parent 738dd5c; the v2 stack is based on main 3b402fb, which contains R1 0d027f6 and the auth fix b42089e). Posted on behalf of @schickling
|
|
Parked (Compounding Manager, Posted on behalf of @schickling
|
Hosted copy opened under Q83 (qssx2n) as extended by Manager (e9841ddd), part of the Fabric re-key stack (#3644 split). Stacked on the previous hosted part. Fabric-mesh posts the independent exact-head GO on this PR. Compounding Manager lands the stack in order.