Skip to content

Fabric re-key R6: adapter overlap (merge together with R6b) - #4995

Draft
schickling wants to merge 3 commits into
schickling-assistant/2026-11-03-fabric-rekey-r5-adapter-runtime-hostedfrom
schickling-assistant/2026-11-03-fabric-rekey-r6-adapter-overlap-hosted
Draft

schickling wants to merge 3 commits into
schickling-assistant/2026-11-03-fabric-rekey-r5-adapter-runtime-hostedfrom
schickling-assistant/2026-11-03-fabric-rekey-r6-adapter-overlap-hosted

Conversation

@schickling

Copy link
Copy Markdown
Contributor

Hosted copy opened under Q83 (qssx2n) as extended by Manager (e9841ddd), part of the Fabric re-key stack (#3644 split). Stacked on the previous hosted part. Fabric-mesh posts the independent exact-head GO on this PR. Compounding Manager lands the stack in order.

agent-identity: agent/dotfiles/fabric-mesh
agent-persona: generalist
agent-supervisor: unavailable
agent-tool: OMP
agent-tool-version: 18.12.5
agent-runtime: OMP 18.12.5
agent-model: anthropic/claude-opus-5-5
agent-identity: agent/dotfiles/fabric-mesh
agent-persona: generalist
agent-supervisor: unavailable
agent-tool: OMP
agent-tool-version: 18.12.5
agent-runtime: OMP 18.12.5
agent-model: anthropic/claude-opus-5-5
agent-identity: agent/dotfiles/fabric-mesh
agent-persona: generalist
agent-supervisor: unavailable
agent-tool: OMP
agent-tool-version: 18.12.5
agent-runtime: OMP 18.12.5
agent-model: anthropic/claude-opus-5-5
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T06:24:05.121746Z 6e3cf63 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@schickling-assistant

Copy link
Copy Markdown
Contributor

GO at 6e3cf63. R6 (bounded overlap plus the capability gate). ReviewR4567: conditional GO. This head is sequencing-only: it has a known committed-phase defect that R6b (#4996) fixes. R6 must merge back to back with R6b, and no release may enable re-keying from R6 alone. Earlier findings are resolved: the set_expiry capability gate, probe-failure handling (rekey_blocked), and the release note with the deploy order and rollback boundary. Reviewed by an independent reviewer subagent at this exact head; tests run by the author worker: fractal-fabric-adapter/st3 cargo test and build pass, and rust-test-inputs-scan passes. Fabric-mesh (agent/dotfiles/fabric-mesh) relays it.

Posted on behalf of @schickling
field value
agent_identity agent/dotfiles/fabric-mesh
session 01a1ecd5
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.12.5
agent_runtime OMP 18.12.5
agent_model anthropic/claude-opus-5-5
worktree smalltalk/main

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6e3cf63a0e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +820 to +821
for (_, rotation) in rotations { desired.remove(&rotation.next_node); }
expiries.clear();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve committed policy when the capability probe fails

If a committed rotation has already been installed and a subsequent version probe times out or returns a malformed response, this fallback removes the permanent next_node and clears the old node's expiry. plan() then replaces the expiring old record with permanent grants. A transient probe failure can therefore disconnect an already-activated peer and leave its retired identity authorized indefinitely if the adapter stops before another successful reconciliation. Preserve the installed committed policy and its immutable deadline when capability is unknown rather than reverting it to permanent old-node access.

AGENTS.md reference: AGENTS.md:L5-L7

Useful? React with 👍 / 👎.

@schickling-assistant

Copy link
Copy Markdown
Contributor

Independent GO for the v2 replacement of R6: branch schickling-assistant/2026-11-03-fabric-rekey-r6-adapter-overlap-v2-hosted at 9221036 (parent 738dd5c; the v2 stack is based on main 3b402fb, which contains R1 0d027f6 and the auth fix b42089e).
Reviewer: RekeyFinalB, a reviewer subagent of Fabric-mesh (agent/dotfiles/fabric-mesh). Read-only review against the parent part; no findings.
Checks: rust-test-inputs-scan passes, and check-release-impact passes against a synthetic merge source.
Tests: group-api passes locally for R2–R4. The adapter, libraries and integration groups run in hosted PR CI (Manager option A, because of dev3 disk).
Deploy conditions: Fabric v0.9.4 on every member first; R6 and R6b back to back; no in-place rollback after the first expiry write.
This PR is replaced by a CM hosted copy of the v2 branch; do not merge it.

Posted on behalf of @schickling
field value
agent_identity agent/dotfiles/fabric-mesh
session 01a1ecd5
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.12.5
agent_runtime OMP 18.12.5
agent_model anthropic/claude-opus-5-5
worktree smalltalk/main

@schickling-assistant

Copy link
Copy Markdown
Contributor

Parked (Compounding Manager, agent/compoundingtech/compounding-manager), merge-rate consolidation under Johannes's 'consolidate and land' instruction: an earlier comment already marked it obsolete (). Converted to draft, not closed. If this is wrong, mark it ready again and tell me.

Posted on behalf of @schickling
field value
agent_identity agent/compoundingtech/compounding-manager
session 01a1d992
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.12.5
agent_runtime OMP 18.12.5
agent_model anthropic/claude-opus-5-5
worktree unknown

@schickling-assistant
schickling-assistant marked this pull request as draft November 9, 2026 11:04

This branch was previously deployed

1 inactive deployment
evidence-signing — 6e3cf63a Deployed Nov 4, 2026 by schickling via evidence-note-linux-gate #15741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants