Repository navigation
Fabric re-key R7: adapter receipts #4997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
schickling
wants to merge
4
commits into
schickling-assistant/2026-11-04-fabric-rekey-r6b-committed-retention-hosted
Choose a base branch
from
schickling-assistant/2026-11-03-fabric-rekey-r7-adapter-receipts-hosted
base: schickling-assistant/2026-11-04-fabric-rekey-r6b-committed-retention-hosted
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+154
−0
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9fb6814
Acknowledge verified Fabric rotation policy and recover both owners s…
schickling-assistant 77ef1a0
Merge Fabric expiry capability gate into receipt stack part
schickling-assistant 27f575b
Merge nonblocking Fabric capability probe failures into receipt stack…
schickling-assistant a10f3be
Merge phase-aware committed cutover retention into receipt stack part
schickling-assistant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"version": 1,"summary": "Publish exact verified Fabric rekey receipts and preserve deny-only renamed-owner crash recovery","replay": {"status": "none","detail": "No graph replay."},"schema": {"status": "none","detail": "Reuses fleet.member-endpoints claims; no database migration."},"rules": {"status": "none","detail": "No checkpoint rule change."},"compatibility": {"status": "changed","detail": "Non-routing rekey metadata is preserved during worker refresh and removed by explicit transport withdrawal."},"downtime": {"status": "none","detail": "No service restart required."},"manual": {"status": "none","detail": "No manual step."},"recovery": {"status": "changed","detail": "Durable recovery replays live writer batches only; renamed-owner recovery cannot add grants or promote an expiring record."}} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When two peers have live rekeys simultaneously, every adapter poll republishes both receipts even after successful acknowledgement. In
smallclaims/src/store/fabric_rekey.rs, receipt publication removes the target's existing receipt and appends it, so posting A then B repeatedly changes endpoint-array ordering on each request. Consequently,publish_fleet_endpoints_lockedcannot take its unchanged-value fast path and appends and seals new replicated claims every five seconds until the transitions expire, despite unchanged installed policy. Filter out exact receipts already present in the local member's endpoints, or make receipt updates order-preserving and idempotent, so unchanged polls do not continuously generate signed membership history. This also follows the repository's reactive-update requirement.AGENTS.md reference: AGENTS.md:L9-L9
Useful? React with 👍 / 👎.