Repository navigation
fix(fleet): preserve Fabric re-key metadata only from authenticated own claims - #5063
Merged
github-merge-queue[bot] merged 1 commit intoNov 4, 2026
Conversation
agent-identity: agent/dotfiles/fabric-mesh agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: openai-codex/gpt-6.1-sol
Contributor
Author
|
GO at b4dbcc9 (ReviewR123, an independent reviewer subagent, security review).
Posted on behalf of @schickling
|
schickling
temporarily deployed
to
evidence-signing
November 4, 2026 13:11 — with
GitHub Actions
Inactive
schickling
temporarily deployed
to
evidence-signing
November 4, 2026 13:12 — with
GitHub Actions
Inactive
schickling
temporarily deployed
to
evidence-signing
November 4, 2026 13:12 — with
GitHub Actions
Inactive
schickling
temporarily deployed
to
evidence-signing
November 4, 2026 13:13 — with
GitHub Actions
Inactive
schickling
temporarily deployed
to
evidence-signing
November 4, 2026 13:19 — with
GitHub Actions
Inactive
schickling
temporarily deployed
to
evidence-signing
November 4, 2026 13:24 — with
GitHub Actions
Inactive
schickling
temporarily deployed
to
evidence-signing
November 4, 2026 13:24 — with
GitHub Actions
Inactive
schickling
temporarily deployed
to
evidence-signing
November 4, 2026 13:39 — with
GitHub Actions
Inactive
Contributor
Author
|
Parked: landed via hosted copy #5067 (merge commit b42089e). Compounding Manager keeps this PR open for Nathan's post-merge review (#4898). Do not close it. Posted on behalf of @schickling
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Codex's P1 finding on #4979 applies:
own_endpoint_fieldsread the latest endpoint claim and checked only its publicmember_key. Another admitted member can sign a claim for the local host subject with that copied key. The membership fold rejects it, but endpoint refresh previously copied its re-key metadata and could republish it with the local signature.Goal and decisions
Verification
Using the required heavy gate-slot wrapper (1800-second maximum hold), cleared agent/runtime environment, isolated Cargo target, and
nix develop --option builders '' -c:cargo test -p smallclaims --lib store::fabric_rekey::tests -- --nocapture: 2 passed, 0 failed.cargo test -p smallclaims: 1,137 passed, 4 ignored, 0 failed across the primary unit/integration/doc-test summaries (excluding child-process re-executions).scripts/rust-test-inputs-scan --check .st/rust-test-inputs.json: passed.python3 scripts/check-release-impact --base 81d36837724c787a4bc8f11a7b19c96584ec3d5c --source HEAD --pr-number 5063: passed; 1 integrated change validated atb4dbcc9995fc7628dda72fc9e0a0ab46e813769e.Before → after: a peer-signed copied-key announcement could supply locally republished rotation metadata → only authenticated current-local-incarnation metadata is preserved, and the copied-key announcement remains rejected.
Complexity and concerns
No new abstraction, dependency, or authentication predicate. Existing membership caching supplies the authenticated view. This prevents laundering new forged metadata; it does not rewrite already published graph history.
Friction and bottlenecks
Heavy-slot queue waits were 2,236s and 1,827s; admitted test holds were 92s and 119s. An initial queue attempt reached its tool deadline before admission and ran no tests. No build/test failures.
References
See #4979 and Codex review comment 4464304987.
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimeagent_modelworktree