Repository navigation
fix(chatgpt): embrace Fractal adapter naming - #5591
Merged
github-merge-queue[bot] merged 2 commits intoNov 7, 2026
Merged
github-merge-queue[bot] merged 2 commits into
github-merge-queue[bot] merged 2 commits into
Conversation
agent-identity: agent/compoundingtech/st-chatgpt agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: openai-codex/gpt-6.1-sol
agent-identity: agent/compoundingtech/st-chatgpt agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: openai-codex/gpt-6.1-sol
Contributor
Author
|
Independent review (reviewer subagent of st-chatgpt), exact head
Posted on behalf of @schickling
|
schickling-assistant
marked this pull request as ready for review
November 7, 2026 09:15
1 of 13 tasks
schickling-assistant
had a problem deploying
to
evidence-signing
November 7, 2026 09:15 — with
GitHub Actions
Failure
schickling-assistant
temporarily deployed
to
evidence-signing
November 7, 2026 09:16 — with
GitHub Actions
Inactive
schickling-assistant
temporarily deployed
to
evidence-signing
November 7, 2026 09:18 — with
GitHub Actions
Inactive
schickling
temporarily deployed
to
evidence-signing
November 7, 2026 09:18 — with
GitHub Actions
Inactive
schickling
temporarily deployed
to
evidence-signing
November 7, 2026 09:19 — with
GitHub Actions
Inactive
schickling
temporarily deployed
to
evidence-signing
November 7, 2026 09:19 — with
GitHub Actions
Inactive
schickling
temporarily deployed
to
evidence-signing
November 7, 2026 09:19 — with
GitHub Actions
Inactive
schickling
temporarily deployed
to
evidence-signing
November 7, 2026 09:23 — with
GitHub Actions
Inactive
schickling
temporarily deployed
to
evidence-signing
November 7, 2026 09:29 — with
GitHub Actions
Inactive
schickling
temporarily deployed
to
evidence-signing
November 7, 2026 09:29 — with
GitHub Actions
Inactive
schickling
temporarily deployed
to
evidence-signing
November 7, 2026 09:43 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The adapter package already uses Fractal naming, but MCP initialization still reports
st-chatgpt, call telemetry emitsst_chatgpt::call, and install instructions prefer legacy binaries.Goal
Use
fractal-chatgptconsistently across the adapter identity, help, error text, installation examples and call telemetry.Decisions
serverInfo.nameand CLI help identifyfractal-chatgpt.fractal_chatgpt::call. The hard allowlist temporarily accepts both targets; it does not rewrite environment directives.RUST_LOG=off,fractal_chatgpt::call=info,st_chatgpt::call=info. An old-target-only EnvFilter will not enable the new events.st-chatgptexecutable behindarn:lmig:smalltalk:2026-11-01-fractal-chatgpt-alias.arn:lmig:smalltalk:2026-11-07-fractal-chatgpt-telemetry-target. Both registry rows are maintained in the legacy-removal checklist in Rename Smalltalk to Fractal (product, binaries, crates, env, wire, state) #3032.packages.fractal-chatgptand bridge-markedpackages.st-chatgpt, and builds the canonical binary with a legacy symlink.Verification
is_call_telemetry_target: canonical and bridge targets pass, unrelated dependency targets are denied.cargo test -j 2 -p fractal-chatgpt(23 library tests passed; the shared allowlist test passed in each binary target; doc tests passed) andcargo clippy -j 2 -p fractal-chatgpt --all-targets -- -D warnings(exit 0). Review-fix rerun: test compilation 1.65 s; Clippy 0.70 s. A bare Cargo attempt could not start because Cargo is only available in the development shell.7f3d4ac6edad7789c5a8d0c1762b2ed90957a70d. Pushed withST_SKIP_EVIDENCE=1; no force push and no CI reruns.manual.status=changed; localscripts/release_notes.py::validatepassed on the fragment.Complexity
No new abstraction or allocation; one temporary allowlist arm.
Concerns
Legacy-only logging directives stop observing new events unless consumers enable both targets before upgrading.
Friction & bottlenecks
Cargo is not available outside the repository development environment. Cold pinned-shell provisioning plus both proofs took 362.46 s; no performance regression claim. The requested
area:live-migrationsrouting label is absent in this repository.Follow-ups
After the downstream pin advances: switch package and executable consumers, rename adapter/tunnel units and deployment paths through their owning deployment, enable both logging directives before rollout, then independently verify consumers and contract bridges. Cached
st_*tool aliases retain their existing 0.2.0 deprecation; daemon wire versions and socket migration remain separately owned.References
See #3032, #4688, #4982 and #5089.
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimeagent_modelworktree