Skip to content

fix(chatgpt): embrace Fractal adapter naming - #5591

Merged
github-merge-queue[bot] merged 2 commits into
mainfrom
schickling-assistant/2026-11-07-chatgpt-fractal-surface-rename
Nov 7, 2026
Merged

github-merge-queue[bot] merged 2 commits into
mainfrom
schickling-assistant/2026-11-07-chatgpt-fractal-surface-rename

Conversation

@schickling-assistant

@schickling-assistant schickling-assistant commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The adapter package already uses Fractal naming, but MCP initialization still reports st-chatgpt, call telemetry emits st_chatgpt::call, and install instructions prefer legacy binaries.

Goal

Use fractal-chatgpt consistently across the adapter identity, help, error text, installation examples and call telemetry.

Decisions

  • MCP serverInfo.name and CLI help identify fractal-chatgpt.
  • Emit call events only under fractal_chatgpt::call. The hard allowlist temporarily accepts both targets; it does not rewrite environment directives.
  • Before a mixed-version upgrade, consumers must set RUST_LOG=off,fractal_chatgpt::call=info,st_chatgpt::call=info. An old-target-only EnvFilter will not enable the new events.
  • Keep the live st-chatgpt executable behind arn:lmig:smalltalk:2026-11-01-fractal-chatgpt-alias.
  • Telemetry bridge: arn:lmig:smalltalk:2026-11-07-fractal-chatgpt-telemetry-target. Both registry rows are maintained in the legacy-removal checklist in Rename Smalltalk to Fractal (product, binaries, crates, env, wire, state) #3032.
  • No flake PR is needed: main already exposes packages.fractal-chatgpt and bridge-marked packages.st-chatgpt, and builds the canonical binary with a legacy symlink.

Verification

  • Added server identity and canonical telemetry emission assertions; existing socket compatibility coverage remains. Production filter and tests share is_call_telemetry_target: canonical and bridge targets pass, unrelated dependency targets are denied.
  • Passed in the pinned Nix environment: cargo test -j 2 -p fractal-chatgpt (23 library tests passed; the shared allowlist test passed in each binary target; doc tests passed) and cargo clippy -j 2 -p fractal-chatgpt --all-targets -- -D warnings (exit 0). Review-fix rerun: test compilation 1.65 s; Clippy 0.70 s. A bare Cargo attempt could not start because Cargo is only available in the development shell.
  • Public leak guard: reviewed changed source, docs and release note; no private hostnames, account paths or credentials introduced. Examples remain neutral.
  • Signed commits; latest head 7f3d4ac6edad7789c5a8d0c1762b2ed90957a70d. Pushed with ST_SKIP_EVIDENCE=1; no force push and no CI reruns.
  • Corrected release fragment to supported manual.status=changed; local scripts/release_notes.py::validate passed on the fragment.

Complexity

No new abstraction or allocation; one temporary allowlist arm.

Concerns

Legacy-only logging directives stop observing new events unless consumers enable both targets before upgrading.

Friction & bottlenecks

Cargo is not available outside the repository development environment. Cold pinned-shell provisioning plus both proofs took 362.46 s; no performance regression claim. The requested area:live-migrations routing label is absent in this repository.

Follow-ups

After the downstream pin advances: switch package and executable consumers, rename adapter/tunnel units and deployment paths through their owning deployment, enable both logging directives before rollout, then independently verify consumers and contract bridges. Cached st_* tool aliases retain their existing 0.2.0 deprecation; daemon wire versions and socket migration remain separately owned.

References

See #3032, #4688, #4982 and #5089.

Posted on behalf of @schickling
field value
agent_identity agent/compoundingtech/st-chatgpt
session 01a145ea
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.12.5
agent_runtime OMP 18.12.5
agent_model anthropic/claude-opus-5-5
worktree smalltalk/main

agent-identity: agent/compoundingtech/st-chatgpt
agent-persona: generalist
agent-supervisor: unavailable
agent-tool: OMP
agent-tool-version: 18.12.5
agent-runtime: OMP 18.12.5
agent-model: openai-codex/gpt-6.1-sol
agent-identity: agent/compoundingtech/st-chatgpt
agent-persona: generalist
agent-supervisor: unavailable
agent-tool: OMP
agent-tool-version: 18.12.5
agent-runtime: OMP 18.12.5
agent-model: openai-codex/gpt-6.1-sol
@schickling-assistant

Copy link
Copy Markdown
Contributor Author

Independent review (reviewer subagent of st-chatgpt), exact head 7f3d4ac6edad7789c5a8d0c1762b2ed90957a70d: GO. No findings remain.

  • Release note: manual.status=changed passes scripts/release_notes.py::validate. The earlier invalid commit on the branch does not affect the merge-commit check, because check_pull_request walks first-parent integrated commits and reads the fragment from the merge commit's effective tree.
  • Telemetry: the event is emitted only under fractal_chatgpt::call. The production filter_fn calls is_call_telemetry_target, which accepts the canonical target and, inside the bridge markers (arn:lmig:smalltalk:2026-11-07-fractal-chatgpt-telemetry-target, Rename Smalltalk to Fractal (product, binaries, crates, env, wire, state) #3032), the legacy st_chatgpt::call. The test covers both arms and rejects a dependency target.
  • Migration order: deployments must set both RUST_LOG directives before they move to a pin that contains this change. Otherwise the EnvFilter suppresses the new target. This is documented in mcp-server.md, the release note and the PR. Changing the configuration first is better than emitting each event twice, which would double-count.
  • serverInfo name fractal-chatgpt: MCP defines serverInfo as implementation metadata, not a persistent connector or approval identity. There is no evidence that this change resets the connector.
  • Docs use fractal-chatgpt as the primary name; the legacy alias appears only in the marked bridge paragraph. Leak guard: no private hostnames or paths.
  • Tests: cargo test -p fractal-chatgpt and clippy -D warnings pass (author run).
Posted on behalf of @schickling
field value
agent_identity agent/compoundingtech/st-chatgpt
session 01a1787a
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.12.5
agent_runtime OMP 18.12.5
agent_model anthropic/claude-opus-5-5
worktree smalltalk/main

@schickling-assistant
schickling-assistant marked this pull request as ready for review November 7, 2026 09:15
@github-merge-queue
github-merge-queue Bot merged commit fa19453 into main Nov 7, 2026
141 of 144 checks passed

This branch was previously deployed

1 inactive deployment
evidence-signing — 7f3d4ac6 Deployed Nov 7, 2026 by schickling via evidence-note-linux-gate #17256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants