[schickling-assistant]

Problem

GitHub observers used a global event operation key (github-event:SUBJECT) with an observation-specific payload (observer, at, detail, and head_sha). Two observers—or two pollers of the same observer—could therefore create the same operation with different request digests, producing operation conflicts.

Goal

Preserve observation provenance while keeping one logical event per global subject and unchanged downstream delivery identities.

Decisions

• Derive github-event-observation:v1:DIGEST from the event subject and the complete recursively canonicalized fields map, using the github-event-observation.v1 hash domain. Exact retries share a key; distinct observations do not.
• Keep generic request hashing unchanged. Canonical-facts-only would discard useful observer-local provenance; observation identity fixes the mismatch without that loss.
• Fold graph event listings and idle queue-exit reads to the canonical first observation per subject. Apply listing limits after deduplication. The correlated selector is supported by the existing claims_subject_kind_accepted_index on (subject, kind, length(accepted_at_unix_ms), accepted_at_unix_ms): equality on subject/kind restricts candidates to one event, with canonical ordering resolving the winner; no new index is added. No EXPLAIN plan is claimed here.
• Old global-key claims and new observation-key claims fold canonically together without rewriting history. New and old producers cannot collide with each other's operation namespace. Two OLD producers can still conflict with each other: the consumer fix covers that.
• Subscription and watch delivery keys remain based on item facts, semantic events, and existing delivery receipts—not these observation operation IDs.

Verification

• scripts/check-public-repo: passed.
• scripts/check-sqlite-large-values: passed (4,310 inventoried sites; not a size proof).
• Added tests for two observers, two pollers of the same observer with differing payloads, exact retry idempotency, full-payload key sensitivity, nested canonicalization, mixed old/new claims, reversed replication arrival, replay, listing limits, subscription delivery deduplication, and idle exit timestamps.
• Rust tests were not run locally, as requested. Hosted CI must verify the PR head fbf5c6d79024fdbd7bae01e285f7344e3ac8437e; no hosted result is claimed yet.
• Author: GPT gpt-6.1-sol. Independent review: GPT ReviewGhKey, GO at this head, no findings. Fractal Product Lead's review: Claude family, GO at this head.

Complexity

Eight files; 220 insertions and nine deletions. No dependencies, schema migration, generic hash changes, or history rewrite. Existing plugin documentation, SQLite reader inventory, and a release note are updated.

Concerns

A canonical-earlier observation that arrives late can lower the selected idle queue-exit timestamp. Later duplicate observations cannot advance it or wake the holder again. Rolling back old producers restores their global-key collision risk.

Friction & bottlenecks

Local Rust execution was intentionally deferred; hosted CI verifies the exact head.

Follow-ups

Landing order: #6334 → #6335 → #6330. This PR lands after the narrow consumer PR (#6334). It does not repair historical operation conflicts, nor prevent conflicts between two unmodified old producers.

References

Producer-side work for schickling/dotfiles#9101. Design: docs/st3/plugins.md; storage review: docs/st3/large-values.md; release note: release-notes/github-event-observation-keys.json.

Posted on behalf of @schickling

field	value
agent_identity	unknown
session	unknown
agent_persona	unknown
agent_supervisor	unavailable
agent_tool	unknown
agent_tool_version	unknown
agent_runtime	unknown
agent_model	unknown
worktree	unknown

[schickling-assistant]

FPL GO for #6335 at head fbf5c6d (FPL is Claude; ReviewGhKey is GPT).

Review

• The operation key is now github-event-observation:v1:<canonical hash(subject, all fields)>. Two pollers, or one observer seen from two nodes, therefore get two different operations instead of one conflicting operation. This removes the #9101 producer shape at its source.
• An exact retry keeps the same key, so producer idempotency still holds.
• The fingerprint covers every field and canonicalizes nested JSON. The test changes each field once and reorders the keys of a nested object.
• Readers fold per event subject to the canonical first observation: the github_events listing and the idle-hold queue exit.
  • The fold result does not depend on arrival order. The test uses forward and reverse stores and covers a legacy-key mix.
  • The fold survives replay_replication_graph.
  • A second observation does not wake an idle holder again.
  • Subscription delivery keeps using item facts, and the test shows exactly one delivery.
• git grep on this head finds no other non-test reader that filters kind='github.event'.
• Old producers that still use the global key can conflict only with each other. fix(store): graph-neutral operation conflicts repair without full replay (#9101) #6334 covers that case.

Conditions: hosted CI green at this exact head. Lands after #6334, alone.

P3 (for the PR body, not blocking):

• Name the index that serves the correlated request.subject=claims.subject AND request.kind='github.event' subquery.
• Record the known effect: a late earlier observation can move the selected idle timestamp backwards, and it never causes a second wake.

Posted on behalf of @schickling

field	value
agent_identity	agent/dotfiles/fractal-product-lead
session	01a1b525
agent_persona	generalist
agent_supervisor	unavailable
agent_tool	OMP
agent_tool_version	18.12.5
agent_runtime	OMP 18.12.5
agent_model	anthropic/claude-opus-5-5
worktree	unknown