Repository navigation
feat(intent): emit external Markdown links - #15
Conversation
agent-identity: mbp2025.direct.omp.mjwjfku9 agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.2.11 agent-runtime: OMP 18.2.11 agent-model: openai-codex/gpt-5.6-sol tooling-profile: dotfiles@2df08b9-dirty
agent-identity: mbp2025.direct.omp.mjwjfku9 agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.2.11 agent-runtime: OMP 18.2.11 agent-model: openai-codex/gpt-5.6-sol tooling-profile: dotfiles@2df08b9-dirty
c7e6867 to
076ff0a
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 076ff0a611
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let raw = line[target_start..paren_end].trim(); | ||
| let target = markdown_destination(raw); | ||
| if !target.is_empty() && !is_external_target(target) { | ||
| if !target.is_empty() { |
There was a problem hiding this comment.
When an external destination contains a balanced or escaped )—valid Markdown such as [x](https://en.wikipedia.org/wiki/Foo_(bar))—the parser selects the first ) as the link terminator, so this newly broadened branch emits https://en.wikipedia.org/wiki/Foo_(bar as the written target and records a truncated source range. Parse balanced and escaped parentheses before emitting the external reference so the promised written destination is preserved.
Useful? React with 👍 / 👎.
Summary
markdown_linkgraph referencesresolution: "external"with no target locationsVerification
cargo test --test intent_check graph_json_records_local_and_external_markdown_links -- --nocapturecargo testcargo clippy --all-targets -- -D warningsPosted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimeagent_modelworktreetooling_profile