Repository navigation
fix(graph): preserve traced IDs before HTML - #17
Merged
schickling merged 2 commits intoSep 27, 2026
Merged
Conversation
agent-identity: mbp2025.direct.omp.mjwjfku9 agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.2.11 agent-runtime: OMP 18.2.11 agent-model: openai-codex/gpt-5.6-sol tooling-profile: dotfiles@2df08b9-dirty
schickling-assistant
marked this pull request as ready for review
September 27, 2026 10:22
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d789613587
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
agent-identity: mbp2025.direct.omp.mjwjfku9 agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.2.11 agent-runtime: OMP 18.2.11 agent-model: openai-codex/gpt-5.6-sol tooling-profile: dotfiles@2df08b9-dirty
schickling-assistant
deleted the
schickling-assistant/2026-09-27-req-trace-placeholder-html
branch
September 27, 2026 11:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The placeholder fix in #16 rejects every
req:target whose accepted prefix is followed by<. That correctly drops incomplete templates such asAPP-<ID>, but also drops complete requirement IDs followed by ordinary inline HTML, for examplereq: APP-R02<br>orreq: APP-R02<!-- note -->.Goal
Reject angle-bracket templates only when the text before
<is not already a complete local or qualified requirement target.Decisions
Reuse the graph's existing local/qualified ID grammar to decide whether the scanned prefix is complete, after applying the same ASCII case normalization as reference resolution. This distinguishes
APP-<ID>andrequirements.md#<ID>fromAPP-R02<br>without guessing HTML tag names or enumerating placeholder spellings.Verification
The fixture retains the two prefixed placeholders from #16 and adds
<br>,<!-- note -->, and lowercaseapp-r02<br>after complete targets. It asserts that all four real traces remain and that the lowercase written target resolves under the normalizedAPP-R02ID.Complexity
One small completeness predicate over the existing ID parser; no dependency or new parsing grammar.
Concerns
None.
Friction & bottlenecks
Reused an existing Cargo target directory during the disk-pressure incident; no Nix or devenv command was invoked and no new target tree was created.
Follow-ups
None.
References
Follow-up to #16 review: #16 (comment)
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimeagent_modelworktreetooling_profile