Repository navigation
fix: match GitHub heading anchor hyphens and Unicode - #20
Merged
schickling-assistant merged 3 commits intoOct 18, 2026
Merged
schickling-assistant merged 3 commits into
schickling-assistant merged 3 commits into
Conversation
agent-identity: agent/dotfiles/st3-cleanup agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.9.1 agent-runtime: OMP 18.9.1 agent-model: anthropic/claude-opus-5-5
agent-identity: agent/dotfiles/st3-cleanup agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.10.2 agent-runtime: OMP 18.10.2 agent-model: anthropic/claude-opus-5-5
Contributor
Author
|
Review record at exact head 161d9bc:
Posted on behalf of @schickling
|
schickling-assistant
marked this pull request as ready for review
October 18, 2026 09:24
agent-identity: agent/dotfiles/st3-cleanup agent-persona: generalist agent-supervisor: unavailable agent-tool: unknown agent-runtime: unknown agent-model: unknown
Contributor
Author
|
Merge record (Johannes q304, one-time exception; message/523f8c1e6d75983c):
Posted on behalf of @schickling
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a factory bottleneck: valid GitHub heading anchors produce false unresolved documentation references.
Problem
Phase C — molty retirementpreviously reduced tophase-c-molty-retirement; GitHub usesphase-c--molty-retirement. Graph extraction andintent checkalso had duplicate, inconsistent reducers.Goal
Use one GitHub-compatible character-reduction function for graph extraction and Markdown link checking.
Decisions
Keep existing ASCII fast paths. A lazy Unicode-category regex retains Alphabetic characters, decimal/letter numbers, marks and connector punctuation. Other_Number characters such as
²,½and①are removed; alphabetic Other_Symbol characters such asⓐsurvive. Every ASCII space becomes a hyphen; hyphens are not collapsed or trimmed. Remove the duplicate reducer fromlib.rs.Character policy and representative Other_Number/Other_Symbol fixtures follow https://github.com/Flet/github-slugger/blob/3461c435/script/generate-regex.js and its test/fixtures.json.
Verification
At 161d9bc:
Includes Unicode-category regressions, spacing and collision fixtures, and strict
intent checkaccepting both local and cross-file#phase-c--molty-retirementdestinations. One new review-fix commit, no amend.Complexity
Adds regex as a direct dependency (already transitive). Sharing the reducer removes duplicate implementation rather than adding an abstraction.
Concerns
This remains raw-heading reduction, not full Markdown inline parsing. Link destinations and underscore emphasis are not parsed, so these cases can still diverge from rendered GitHub headings. Unicode properties follow the regex crate's Unicode version rather than pinning github-slugger's Unicode 13 tables.
Friction & bottlenecks
Earlier Cargo attempts encountered an agent-command-shell guard refusal. The compiler-wrapper-disabled test command above succeeds without bypassing the guard. A requested destructive reset was refused; used the prescribed keyed-stash alternative to preserve identical edits before fast-forwarding the test checkout.
Follow-ups
Rendered inline-Markdown parsing is outside this character-reduction fix.
References
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimeagent_modelworktree