This repository was archived by the owner on Sep 29, 2026. It is now read-only.
Repository navigation
Replace private machine and agent names in help text, comments and tests - #186
Merged
Merged
Conversation
The help examples for attach, peek, send and list used a real machine as the --remote peer; they now use example-host, which also matches the Rust pty's help fixtures byte for byte. Comments that credited a measurement to a named agent on a date now say only where it was measured. Test data uses example.pty and /home/example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #185, which fixed the README. Running the private-names check (
scripts/check-private-names.pyfrom compoundingtech/pty) over this repository found 12 more lines:pty attach|peek|send|list --helpexamples used a real machine as the--remotepeer. They now useexample-host, the same text the Rust pty's help fixtures carry.tests/env-isolation.test.tsandtests/filter.test.tsuseexample.ptyand/home/example.tests/remote-fabric.test.tsnames the Linux failure by platform, not by machine.No behaviour changes. The repository is archived again once this merges, so no CI workflow is added here.