Repository navigation
Check CI for private machine, person, and agent names - #37
Merged
Merged
Conversation
Public repositories hold invented examples only: no machine or host names, no personal home paths, no real person IDs, no internal agent or fleet IDs. scripts/check-private-names.py fails on any of those in a tracked file, and a new workflow runs it on every push and pull request. What it found here is now invented: a machine name in an e2e comment, the tailnet hostname example in DaemonRuntime and the tailscale URL tests, and home directories in the peers-file and session-list-view tests. The SSH user in the README and the peers tests is alex, and the comments that credited a bug report to a person no longer do.
The Node pty moved to compoundingtech/pty-original-experiment and compoundingtech/pty now holds the Rust port, so the locked rev 0a9be8c is no longer in the repository the input names and `nix flake check` fails with a 404 fetching its tarball. Same rev, same narHash, new repository.
Collaborator
Author
|
Added a second commit, 7-line diff: the Nix check was failing before this PR's changes, fetching the locked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public repositories get invented examples only. That means no machine or host names, no personal home paths, no real person IDs and no internal agent or fleet IDs.
The check
scripts/check-private-names.pychecks every tracked text file. It fails on:/home/NAMEor/Users/NAMEpath whose NAME does not start withexampleperson/NAMEID other thanperson/alexorperson/example…agent/fleet/ID.private-names-allow..github/workflows/private-names.ymlruns the check on every push to main and every pull request.What it found, now invented
integration/e2e.test.ts: a machine name in the label example is nowexample.local (cli).src/relay/daemon-runtime.ts: the tailnet hostname example is nowexample-host.example-tailnet.ts.net.test/daemon-runtime.test.ts: the tailscale URL tests useexample.ts.net.test/peers-file.test.ts:/home/uis now/home/example.test/session-list-view.test.ts:/Users/meand a personal/Users/…path are now/Users/example.browser/src/session-list-view.ts: the comment says "Linux home directories" instead of a/home/…path.alex.Tested locally
mainwith 14 findings and passes on this branch.vitest run test/session-list-view.test.tspasses 41 andtest/peers-file.test.tspasses 22. Those tests run against a sibling../ptychecked out from pty-original-experiment.test/local-status-probe.test.tscan't load@compoundingtech/pty/clientwithout a built Node pty, andtest/daemon-runtime.test.tshangs in the global setup.main's versions of both files do exactly the same, so neither comes from this change. My edits to those two files change only string literals and one test name.