Repository navigation
fix: store an absolute cwd in session metadata - #221
Open
schickling-assistant wants to merge 3 commits into
Open
schickling-assistant wants to merge 3 commits into
schickling-assistant wants to merge 3 commits into
Conversation
agent-identity: agent/compoundingtech/compounding-manager agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: openai-codex/gpt-6.1-sol
agent-identity: agent/compoundingtech/compounding-manager agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: openai-codex/gpt-6.1-sol
agent-identity: agent/compoundingtech/compounding-manager agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: openai-codex/gpt-6.1-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Relative
cwdvalues such as.were copied into run metadata. After the daemon vanishes, worktree-reclaim tools cannot classify those records against an absolute worktree path.Change
std::path::absolute, then freeze that cwd in the config before metadata publication or child creation, in both ordinary and operation-mode launches..and an absolute symlink path, plus validation-error coverage and README documentation.Verification
Checks ran on Linux through the repository's
nix developshell with heavy-work admission. Final head:c2d8ac40d312b9043e2266448c3019540e452111.Final-head raw results:
Formatting (repo Nix shell, rustc 1.97.0 / rustfmt 1.9.0):
The scoped command was
rustfmt --check --edition 2024 --config skip_children=trueon the four changed Rust files. Every reported formatting hunk is in existing, unchanged code; none is in this change's added/modified lines. Baseline formatting was not rewritten. CI treats formatting and clippy as reporting-only.The complete affected-crate run on
30492ead7ce4180e7037be5bacab3b369db0c81dreported:It failed four binaries. To distinguish regressions from baseline failures, each was also run on
origin/main(d50ad1b3c839e49c8115e1d9cc93048e6252e090) on the same host and Nix shell, with--test-threads=1:Raw baseline results:
Earlier implementation check on
efb192cf47bb84c5780c861480c297cbe43ab3a9exposed a missing mutable worker binding, fixed in the next signed commit:NOT RUN: complete affected-crate suite again after the test-only fixture correction; full workspace tests; release build; macOS checks; record migration/reclaim (out of scope).
Complexity and concerns
No new dependency or abstraction; a shared launch-time helper serves both launch modes. Existing formatting drift and the reproduced main-branch test failures remain visible above.
Friction
The regression initially reused a registry root that the daemon test harness deletes on drop; each case now owns a separate root. No production behavior was changed to accommodate the fixture.
Scope
No existing run records were modified. No migration or reclaim operation is included.
Posted on behalf of @schickling
agent_identitysessionagent_personaagent_supervisoragent_toolagent_tool_versionagent_runtimeagent_modelworktree