This repository was archived by the owner on Sep 29, 2026. It is now read-only.
Repository navigation
Replace private machine names and home paths, and check CI for them - #109
Merged
Merged
Conversation
Test identities and catalog fixtures used the fleet's real machines as host prefixes; they now use example-linux and example-mac, which keep the same sort order the enumeration test asserts. The sync-fabric error example names example-host, and the README and rsyncd tests use /Users/example and /home/example. scripts/check-private-names.py, the same check as in pty, pty-relay, pty-layout and transplant, now runs on every pull request with a self-test that proves it still catches each kind of name.
The Node pty moved to compoundingtech/pty-original-experiment and compoundingtech/pty now holds the Rust port, so the locked rev 0a9be8c is no longer in the repository the input names. Same rev, same narHash, new repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public repositories hold invented examples only. Running
scripts/check-private-names.py(the check pty, pty-relay, pty-layout and transplant run) over this repository found 45 lines:<host>.bob,<host>.cos-claude,host = "<host>"). They now useexample-linuxandexample-mac, which keep the orderconvoy-layout.test.tsasserts after.sort().sync-fabric.ts's error example saysfabric:example-host./Users/exampleand/home/example. Oneinit.test.tscomment is reworded so it doesn't look like a home path.A second commit repoints the
ptyflake input to compoundingtech/pty-original-experiment. That's where the Node pty now lives, since compoundingtech/pty holds the Rust port. Same rev0a9be8c, same narHash; pty-relay#37 made the same change.The PR also adds the check and a
Private namesworkflow. The repository is archived again once this merges.