RSec Admin Nomination Page - "New Officer" blank error check + Return properly after redirect#321
Open
ochan1 wants to merge 2 commits intocompserv:masterfrom
Open
RSec Admin Nomination Page - "New Officer" blank error check + Return properly after redirect#321ochan1 wants to merge 2 commits intocompserv:masterfrom
ochan1 wants to merge 2 commits intocompserv:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://stackoverflow.com/questions/1183506/make-blank-params-nil
Using Election.new is fine (as long as the other parameters are fine also) https://stackoverflow.com/questions/33637552/save-activerecord-object-without-commit-rails-4
The issue that made Nominations create a buggy entry was this: rails/rails#26363
Code continued to keep running despite blank Person and Position params ("invalid" entries are not covered here, but a minor issue since only this page is running the function, and by UI limits the input available)