This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Remove reference to protected $_id because it is already declared in Base Parent Class#199
Open
awasson wants to merge 1 commit into
Open
Remove reference to protected $_id because it is already declared in Base Parent Class#199awasson wants to merge 1 commit into
awasson wants to merge 1 commit into
Conversation
…t CRM_Core_Form Class
awasson
changed the title
Contributor
|
Looks like this has been fixed in the maintained version of this extension: https://lab.civicrm.org/extensions/booking/-/commit/31d9bcd4580f6f03e61bfdf900b6d1b313651f8f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CiviCRM Base class, "CRM_Admin_Form extends CRM_Core_Form" declares a public $_id variable and redeclaring it as protected causes a fatal error. This pull request removes protected $_id from 6 forms although the reference to protected $_id was already commented out in CRM/Booking/Form/SelectResource.php