fix: sweep-cleanup lingering sandboxes after each benchmark mode#32
Open
HeyGarrison wants to merge 1 commit intomasterfrom
Open
fix: sweep-cleanup lingering sandboxes after each benchmark mode#32HeyGarrison wants to merge 1 commit intomasterfrom
HeyGarrison wants to merge 1 commit intomasterfrom
Conversation
After each provider finishes a benchmark mode (sequential, staggered, burst), call compute.sandbox.list() and destroy any sandboxes still alive. This prevents resource accumulation across modes — e.g. sandboxes from sequential/staggered modes eating quota before burst starts. Previously we only relied on per-iteration finally blocks, but those can miss sandboxes when destroy times out, fails silently, or the provider's delete API is eventually consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compute.sandbox.list()and destroy any sandboxes still aliveProblem
We run 3 modes per provider: sequential (1 sandbox), staggered (100 sandboxes), burst (100 sandboxes) = ~201 total. The per-iteration
finallyblocks calldestroy(), but:@computesdk/daytonasilently dropsautoStopInterval/autoDeleteIntervalfrom sandbox options, so sandboxes aren't ephemeralBy burst mode, dozens of sandboxes from earlier modes are still lingering, eating quota.
Fix
Added
cleanupAllSandboxes(compute, providerName)that runs after each mode per provider:compute.sandbox.list()(30s timeout)Promise.allSettled(15s timeout each)