Add UnitTypeResource scoped to a project - #3
Merged
Conversation
Expose unitTypes(string $projectUuid) on the connector returning a
UnitTypeResource with list() and get(string $uuid). Both methods
dispatch project-scoped Saloon requests against
/projects/{projectUuid}/projectwoningen/ and its detail endpoint.
Cover the new code with focused request and MockClient-backed
resource tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnitTypeResourceexposinglist()andget(string $uuid)returningSaloon\Http\ResponseGetUnitTypesRequestandGetUnitTypeRequestunderRequests/UnitTypes, both scoped to a project uuid$nbo->unitTypes(string $projectUuid)Endpoints
list()→GET /projects/{projectUuid}/projectwoningen/get($uuid)→GET /projects/{projectUuid}/projectwoningen/{uuid}/Tests
GetUnitTypesRequest: HTTP method, publicprojectUuid, resolved endpointGetUnitTypeRequest: HTTP method, publicprojectUuidanduuid, resolved endpointUnitTypeResource:list()andget()dispatch the right project-scoped request and return the mocked response (verified with closure-basedMockClient::assertSentchecking the project uuid, uuid, and resolved endpoint), plus direct instantiationNieuwbouwOffice:unitTypes(string $projectUuid)returns aUnitTypeResource26 tests passing locally with
vendor/bin/pest(37 assertions).Usage