Add Project DTO and return it from project endpoints - #4
Merged
Conversation
Introduce Project data object with a fromResponse(array) factory that maps the API's Project_UUId/Project_Titel/Project_Timestamp keys onto uuid/title/created_at/updated_at. GetProjectRequest::createDtoFromResponse delegates the field mapping to the DTO, and ProjectResource::get now returns the typed Project directly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
GetProjectsRequest::createDtoFromResponse maps data.objects through Project::fromResponse, and ProjectResource::list now returns Project[] via ->dto() (matching get()'s shape). Project::fromResponse prefers Laatst_Bijgewerkt for updated_at when present, falling back to Project_Timestamp so the single-project endpoint is unaffected. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProjectDTO that maps the API'sProject_UUId/Project_Titel/Project_Timestamp/Laatst_Bijgewerktfields into typed, readonly propertiescreateDtoFromResponseintoGetProjectRequestandGetProjectsRequest, and updateProjectResource::get()/list()to return the DTO(s) instead of rawResponseobjects.DS_StorefilesTest plan
vendor/bin/pest— DTO, request, and resource tests cover both single and list responses