Add UnitResource for project-scoped woningen endpoints - #7
Merged
Conversation
Mirror the UnitTypeResource shape for the /projects/:uuid/woningen list and detail endpoints so callers have a typed entry point for individual units (woningen) alongside the existing unit-type resource. Returns raw Saloon responses for now; a DTO layer can follow once the response shape is captured. Changelog: added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetUnitsRequestandGetUnitRequestwrapping/projects/:project_uuid/woningen/and/projects/:project_uuid/woningen/:uuid/.UnitResourcewithlist()andget()methods, mirroring the shape ofUnitTypeResource.NieuwbouwOffice::units(string \$projectUuid): UnitResourceon the connector.Saloon\\Http\\Responsefor now — a typedUnitDTO can follow in a separate PR once we have the woningen response shape, same staged approach we used for UnitType.Test plan
vendor/bin/pest— full suite green locally (42 passed, 228 assertions; +10 new tests).\$nbo->units('<project-uuid>')->list()and confirm aResponsecomes back with the expecteddata.objectsshape.->get('<unit-uuid>')and confirm a single-object response comes back.