Feature/rockets zero - #462
Closed
MrMaz wants to merge 64 commits into
Closed
Conversation
|
To view this pull requests documentation preview, visit the following URL: docs.page/btwld/nestjs-modules~462 Documentation is deployed and generated using docs.page. |
Closed
tnramalho
reviewed
May 15, 2026
Collaborator
There was a problem hiding this comment.
PR Review — Feature/rockets zero
Medium-priority issues
- README is out of sync.
README.mdstill listsnestjs-typeorm-ext(deleted) and omits the newrockets-app,rockets-otp,rockets-cache,rockets-invitation,rockets-role,rockets-federated,rockets-repository,rockets-repository-typeorm. - No CI updates. A rewrite that renames every package and consolidates eight modules into one doesn't touch
.github/workflows/. Worth verifying that the existing workflows still build/test, especially given the broken legacy packages above.
Recommendation
Do not merge in current form. The two blockers (deleted typeorm-common referenced by tsconfig, and surviving nestjs-* packages depending on deleted modules) will break yarn install, tsc --build, and any consumer pulling the workspace. The empty PR description and version drift compound the risk because reviewers and future maintainers can't reason about the change.
Suggested path:
- Fix the two blockers (remove stale
tsconfigref; either port or remove the brokennestjs-*packages).
🤖 Review generated with Claude Code
tnramalho
previously approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.