Open
Conversation
hissy
requested changes
Aug 14, 2025
controller.php
Outdated
| protected $appVersionRequired = '8.0.0'; | ||
| protected $pkgVersion = '1.0.2'; | ||
| protected $appVersionRequired = '9.0.0'; | ||
| protected $pkgVersion = '2.0.2'; |
Member
There was a problem hiding this comment.
Thank you for your contribution! I'll test it, but the changes in this pull request do not require a minimum supported version change. Can you keep it, and change the package version to 1.1.0?
Author
|
sure, NP, I did 2.x while concrate market holds 2.0.0 in fact, changes require version 9.x while block majorca_slick_slider and majorca_testimonial_carousel inside FORM.php changin html tags which allow switch tabs while edit. And infact only this. " |
Attempted to call an undefined method named "getBlockTypeToolsURL" of class "Concrete\Core\Application\Service\Urls". Did you mean to call e.g. "getBlockTypeAssetsURL", "getBlockTypeCssURL" or "getBlockTypeIconURL"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to version 2.0.0/1.0.2