Skip to content

AVX512 support#439

Open
isuruf wants to merge 10 commits into
conda-forge:mainfrom
isuruf:avx512
Open

AVX512 support#439
isuruf wants to merge 10 commits into
conda-forge:mainfrom
isuruf:avx512

Conversation

@isuruf
Copy link
Copy Markdown
Member

@isuruf isuruf commented Aug 4, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16729133202. Examine the logs at this URL for more detail.

@isuruf
Copy link
Copy Markdown
Member Author

isuruf commented Aug 4, 2025

@hmaarrfk can we merge this as well before I make the macOS packages?

@hmaarrfk
Copy link
Copy Markdown
Contributor

hmaarrfk commented Aug 4, 2025

Yes ok with me. Please merge when you feel confident.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Feb 19, 2026

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/22456640361. Examine the logs at this URL for more detail.

…6.02.19.14.04.59

Other tools:
- conda-build 25.9.0
- rattler-build 0.47.1
- rattler-build-conda-compat 1.4.5
Comment thread recipe/meta.yaml
- cat test_tensorflow.py # [unix]
- run python test_tensorflow.py # [build_platform == target_platform]
- tf_upgrade_v2 --help # [build_platform == target_platform]
- run tf_upgrade_v2 --help # [build_platform == target_platform]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't fix the test:

/home/conda/feedstock_root/build_artifacts/tensorflow-split_1771543504012/test_tmp/run_test.sh: line 10: run: command not found

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're debugging, please restrict testing here to one (preferably non-CUDA) build.

Comment on lines -19 to -22
- 12.6
- None
- 12.8
- 12.9
Copy link
Copy Markdown
Member

@h-vetinari h-vetinari Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this migrator should not be deleted, we still need 12.8 here (until 2.20 I guess?); it already has use_local: true so you can simply move 12.9 before 12.8 in the ordering here. and a rerender should do the correct thing (== stay on 12.8)

@h-vetinari
Copy link
Copy Markdown
Member

As an overall point; not sure if we're doing AVX512 builds anywhere else yet? Are there some benchmarks that we can reference for how much of a win this is over AVX2? Makes a big difference if it's 5% or 50%.

@h-vetinari
Copy link
Copy Markdown
Member

While you're debugging, please restrict testing here to one (preferably non-CUDA) build.

This is not a difficult demand. I'm cancelling the builds.

@isuruf
Copy link
Copy Markdown
Member Author

isuruf commented Feb 26, 2026

I skipped level=1, but since level=3 and level=4 failed and cuda vs non-cuda failed with different errors, I wanted to check all 4 builds.

@h-vetinari
Copy link
Copy Markdown
Member

h-vetinari commented Feb 26, 2026

We have a pending pytorch merge that fixes several issues, which is IMO pretty self-evidently of higher priority than debugging work, especially for features rather than fixes. The PR here would block the server for 8-12h as-is, which I think is not reasonable under the circumstances. Though you should be able to run them in parallel if you're willing to try the cirrus setup from conda-forge/pytorch-cpu-feedstock#484

@h-vetinari
Copy link
Copy Markdown
Member

I had restarted all builds here as soon as runners became available again ~36h ago, but the interface with cirun is pretty fragile these days, and only one job started. The only recovery is to cancel and restart, but since the GH UI has no third way between "restart all failed jobs" and "restart one job", the former would have meant rerunning the just-failed job again. In any case, all the last of the 4 jobs whose output you wanted to see has now been started, 3 are done already.

@isuruf
Copy link
Copy Markdown
Member Author

isuruf commented Mar 6, 2026

Moved some fixes from this PR to #477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants