Skip to content

fix: load yaml with SafeLoader#5716

Closed
trim21 wants to merge 1 commit intoconda:mainfrom
trim21:patch-1
Closed

fix: load yaml with SafeLoader#5716
trim21 wants to merge 1 commit intoconda:mainfrom
trim21:patch-1

Conversation

@trim21
Copy link
Copy Markdown

@trim21 trim21 commented May 19, 2025

Description

this function is used with get_package_combined_spec and is used to render config files in conda-smithy.

But, the BaseLoader parse bool true / false as str, which cause a inconsistent at render time and building time on the build.skip in rattler.build

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot
Copy link
Copy Markdown
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @trim21.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1161), and ping the bot to refresh the PR.

@trim21 trim21 marked this pull request as ready for review May 19, 2025 05:53
@trim21 trim21 requested a review from a team as a code owner May 19, 2025 05:53
@trim21 trim21 closed this May 19, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Done in 🔎 Review May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants