Skip to content

Replace logger.warn w/ logger.warning - #646

Merged
maresb merged 1 commit into
conda:mainfrom
zklaus:warn-to-warning
Jun 11, 2024
Merged

maresb merged 1 commit into
conda:mainfrom
zklaus:warn-to-warning

Conversation

@zklaus

@zklaus zklaus commented Jun 11, 2024

Copy link
Copy Markdown
Contributor

Description

This replaces calls to logger.warn with logger.warning. The former has been deprecated since Python 3.3 and generates DeprecationWarnings that can make output particularly in debugging and testing more noisy than necessary.

Also see conda/conda#13963.

@netlify

netlify Bot commented Jun 11, 2024

Copy link
Copy Markdown

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit b0a50b1
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/6668357fde39280008ce83e0
😎 Deploy Preview https://deploy-preview-646--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@maresb

maresb commented Jun 11, 2024

Copy link
Copy Markdown
Contributor

Thanks @zklaus!

Most of the changes are on vendored code, so that should not be changed outside of revendoring or specific patches.

The changes to conda_lock/conda_solver.py look good though! Would you be able to rebase with just this? Thanks!

@zklaus

zklaus commented Jun 11, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the quick feedback, @maresb! I did put those changes into a separate commit because I expected this discussion :) The changes in vendored code are all in conda. The corresponding PR for conda is conda/conda#13963.

What's the procedure for revendoring here?

@maresb

maresb commented Jun 11, 2024

Copy link
Copy Markdown
Contributor

Roughly the procedure is

  1. Install vendoring
  2. Update vendor.txt to update the version
  3. Run vendoring update
  4. Fix breakage

Now may actually be a good time to revendor since we can do it concurrently with #637. Thanks for your interest in this @zklaus!

@zklaus

zklaus commented Jun 11, 2024

Copy link
Copy Markdown
Contributor Author

Hm. If we are doing this, it may be best to wait for a release of conda that includes the fixes, so how about this:

  1. I'll remove the changes to the vendored code here
  2. We merge this PR and consider it enough to unblock Replace logger.warn w/ logger.warning conda#13963
  3. We merge Replace logger.warn w/ logger.warning conda#13963
  4. Wait for the next conda release
  5. Revendor to that version
  6. Profit

@zklaus
zklaus force-pushed the warn-to-warning branch from f49c39e to b0a50b1 Compare June 11, 2024 11:31
@zklaus
zklaus marked this pull request as ready for review June 11, 2024 12:20
@zklaus
zklaus requested a review from a team as a code owner June 11, 2024 12:20
@maresb
maresb merged commit e12b6e8 into conda:main Jun 11, 2024
@maresb

maresb commented Jun 11, 2024

Copy link
Copy Markdown
Contributor

perfect, thanks @zklaus!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants