Replace logger.warn w/ logger.warning - #646
Conversation
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks @zklaus! Most of the changes are on vendored code, so that should not be changed outside of revendoring or specific patches. The changes to |
|
Thanks for the quick feedback, @maresb! I did put those changes into a separate commit because I expected this discussion :) The changes in vendored code are all in conda. The corresponding PR for conda is conda/conda#13963. What's the procedure for revendoring here? |
|
Roughly the procedure is
Now may actually be a good time to revendor since we can do it concurrently with #637. Thanks for your interest in this @zklaus! |
|
Hm. If we are doing this, it may be best to wait for a release of conda that includes the fixes, so how about this:
|
|
perfect, thanks @zklaus!!! |
Description
This replaces calls to
logger.warnwithlogger.warning. The former has been deprecated since Python 3.3 and generatesDeprecationWarnings that can make output particularly in debugging and testing more noisy than necessary.Also see conda/conda#13963.