fix: handle fn field conversion for archive source files#503
Closed
xingzihai wants to merge 1 commit intoconda:mainfrom
Closed
fix: handle fn field conversion for archive source files#503xingzihai wants to merge 1 commit intoconda:mainfrom
xingzihai wants to merge 1 commit intoconda:mainfrom
Conversation
Issue conda#500: For archive source files, converting fn to file_name changes behavior In V1, file_name on archives disables automatic extraction, which is not desired Changes: - Add ARCHIVE_FILE_EXTENSION regex to detect archive file extensions - For archive sources, remove fn field and warn user - For non-archive sources, perform normal fn -> file_name conversion - Update tests to verify the new behavior Fixes conda#500
Contributor
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @xingzihai. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1307), and ping the bot to refresh the PR. |
Collaborator
|
No. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #500
For archive source files (.tar.gz, .zip, .7z, etc.), converting
fntofile_namechanges behavior in V1 format. In V1,file_nameon archives disables automatic extraction, which is not desired.Changes:
ARCHIVE_FILE_EXTENSIONregex to detect archive file extensionsfnfield and warn userfn->file_nameconversionTesting:
fnwith a warningfntofile_nameThis ensures that archive sources maintain automatic extraction behavior when converting from V0 to V1 format.