Skip to content

Remove code coverage from codecov - #108

Open
kowser-orkes wants to merge 1 commit into
mainfrom
ci/disable-codecov-comment
Open

Remove code coverage from codecov#108
kowser-orkes wants to merge 1 commit into
mainfrom
ci/disable-codecov-comment

Conversation

@kowser-orkes

Copy link
Copy Markdown
Contributor

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

Changes in this PR

  • remove the Codecov upload step

Alternatives considered

  • keep Codecov and just silence its PR comment

@mp-orkes mp-orkes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upload is gone, is -coverprofile=coverage.out -covermode=atomic on line 35 still worth keeping? Nothing reads the file anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants