feat(files): enforce workflow-scoped file transfers - #1355
Merged
Conversation
6 tasks
Collaborator
Author
|
Companion Java SDK PR: conductor-oss/java-sdk#137. The SDK PR consumes the workflow-scoped routes introduced here and documents the coordinated migration. |
manan164
approved these changes
Jul 20, 2026
shaileshpadave
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Makes file operations workflow-aware end to end:
fileSizein metadataBreaking change: the previous unscoped mutation and metadata routes are removed. Clients must pass workflow context on every operation.
Issue #
Tests
./gradlew :conductor-core:test --tests org.conductoross.conductor.core.storage.converter.FileModelConverterTest --tests org.conductoross.conductor.core.storage.FileStorageServiceImplTest :conductor-rest:test --tests org.conductoross.conductor.rest.controllers.FileResourceTest -x :conductor-ai:compileJava./gradlew :conductor-common:spotlessJavaApply :conductor-core:spotlessJavaApply :conductor-rest:spotlessJavaApply :conductor-awss3-storage:spotlessJavaApply :conductor-e2e:spotlessJavaApply :conductor-test-harness:spotlessJavaApplyAlternatives considered
Keeping unscoped routes or trusting a supplied file handle alone would leave upload mutations detached from ownership. Proxying file bytes through Conductor was also rejected; signed URLs retain the direct-to-storage data path.