Resolve #426: WaitTask base class sets wrong inputParameter key 'wait_until' instead of 'until' - #463
Open
v1r3n wants to merge 2 commits into
Open
Resolve #426: WaitTask base class sets wrong inputParameter key 'wait_until' instead of 'until'#463v1r3n wants to merge 2 commits into
v1r3n wants to merge 2 commits into
Conversation
…acb2-673eb0aca4df:baseline] Conductor-Original-Branch: main Conductor-Original-Head: 5323c3d
|
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #426
Summary
Correct the direct
WaitTask(wait_until=...)serialization key and add a focused unit regression test. No server integration or subclass changes are needed.Subtasks
WaitTask.__init__to storewait_untilunder the server-recognizeduntilinput key. Add unit coverage asserting the direct constructor emits{"until": ...}withoutwait_until, while preserving existing duration behavior and the already-correctWaitUntilTaskbehavior.Verification
WaitTask(wait_until=...)now serializes as{"until": ...}, matching the existing server-recognized key used byWaitUntilTask.tests/unit/workflow/test_wait_task.py, including an assertion that the obsoletewait_untilkey is absent. No server integration or subclass implementation changes were introduced.coveragefailed withFileNotFoundErrorbefore any tests ran. This is an unavailable/malformed test command in this environment, not evidence of a project-code failure.Automated resolution by the Conductor coding harness (code_parallel).