Open
Conversation
This reverts commit cb2e102.
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull request overview
This PR removes the Go-based “live” integration test suite (which ran the real CLI against Confluent Cloud) along with the supporting Makefile targets and Semaphore promotion, and it also downgrades several Go module dependencies.
Changes:
- Deleted the
test/live/live-test harness, its CRUD-style live tests, and accompanying README. - Removed live-test build/run targets from
Makefileand from the Debian packaging patch. - Removed the Semaphore “Run live integration tests” promotion and deleted the live-tests pipeline file; updated Go module versions (notably
go-git) and associatedgo.sumentries.
Reviewed changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/live/service_account_live_test.go | Removes live CRUD test for service accounts. |
| test/live/schema_registry_live_test.go | Removes live CRUD test for Schema Registry schemas/subjects/config. |
| test/live/login_live_test.go | Removes live login/logout verification test. |
| test/live/live_utils.go | Removes helper utilities used by the live test harness. |
| test/live/live_test.go | Removes the live test suite harness, state management, and command runner. |
| test/live/kafka_topic_live_test.go | Removes live CRUD test for Kafka topics. |
| test/live/kafka_consumer_group_live_test.go | Removes live list test for Kafka consumer groups. |
| test/live/kafka_cluster_live_test.go | Removes live CRUD test for Kafka clusters (including provisioning wait). |
| test/live/kafka_acl_live_test.go | Removes live CRUD test for Kafka ACLs. |
| test/live/iam_rbac_live_test.go | Removes live CRUD test for IAM RBAC role bindings. |
| test/live/environment_live_test.go | Removes live CRUD test for environments. |
| test/live/connect_live_test.go | Removes live CRUD/lifecycle test for Connect managed connectors. |
| test/live/api_key_live_test.go | Removes live CRUD test for API keys. |
| test/live/README.md | Removes documentation for running/writing live integration tests. |
| go.mod | Downgrades github.com/go-git/go-git/v5 and multiple indirect dependencies. |
| go.sum | Updates checksums to reflect the downgraded dependency graph. |
| debian/patches/standard_build_layout.patch | Removes live-test related targets from the Debian Makefile patch content. |
| Makefile | Removes build-for-live-test and all live-test* targets. |
| .semaphore/semaphore.yml | Removes the promotion entry that triggered the live integration tests pipeline. |
| .semaphore/live-tests.yml | Deletes the Semaphore pipeline definition for live integration tests. |
| .gitignore | Stops ignoring /test/live/bin/ (previously used for the live-test binary). |
Comments suppressed due to low confidence (1)
.semaphore/semaphore.yml:106
- Removing the "Run live integration tests" promotion disables the ability to run those live tests from Semaphore. If live tests are still a supported verification path, consider keeping a manual promotion (or documenting the replacement) so regressions can still be validated end-to-end when needed.
promotions:
- name: "Run macOS builds (manual)"
pipeline_file: ".semaphore/macos.yml"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert the automated PR to update go-git to see if that was the source of the current test issues on Windows or if it was just coincidental.