align plugin versions for modules not depending on common#266
align plugin versions for modules not depending on common#266Xavier Léauté (xvrl) wants to merge 1 commit intomasterfrom
Conversation
Ewen Cheslack-Postava (ewencp)
left a comment
There was a problem hiding this comment.
patch looks fine, but i haven't looked into the CI build failure. one thing to keep in mind is testing. we could do muckrake or packaging test, but this potentially has broader fallout, e.g. connectors. some stuff might not use this, but just want to be careful since a change here can affect so many repos
34a634b to
f6920f0
Compare
Ewen Cheslack-Postava (ewencp)
left a comment
There was a problem hiding this comment.
LGTM, but should still get a green build. Xavier Léauté (@xvrl) the most recent failure is in a downstream build and seems like probably something else was just broken at the time, probably just retriggering would resolve.
|
Ewen Cheslack-Postava (@ewencp) sounds good. Before we merge I'd like to have Grace Chen (@gracechensd) approve, since this will cause the build to fail once merged until we switch to the new property syntax. |
see #265 for context
f6920f0 to
d105e84
Compare
|
|
In #265 we had to downgrade plugins due to inconsistent versions being used across different modules. This upgrades deploy and install plugins in all our modules, including which do not inherit from common pom.
This should allow us to switch to the new syntax for
alt*DeploymentRepositoryto workaround authentication issues with the deprecated syntax. (see https://issues.apache.org/jira/browse/MDEPLOY-246)