Avoid deadlock merge requests order#241
Draft
Francesco Capponi (FreCap) wants to merge 10 commits into
Draft
Conversation
added 2 commits
September 14, 2022 19:33
The existing code implies that the executor will always run the queries in order, but this is not a hard guarantee of the executor. This can cause newer merge batches getting in front of merge batches, and locking the thread, which causes a deadlock
The existing code implies that the executor will always run the queries in order, but this is not a hard guarantee of the executor. This can cause newer merge batches getting in front of merge batches, and locking the thread, which causes a deadlock
The existing code implies that the executor will always run the queries in order, but this is not a hard guarantee of the executor. This can cause newer merge batches getting in front of merge batches, and locking the thread, which causes a deadlock
Francesco Capponi (FreCap)
force-pushed
the
avoid-deadlock-merge-requests-order
branch
from
c752bc5 to
ae09321
Compare
Francesco Capponi (FreCap)
force-pushed
the
avoid-deadlock-merge-requests-order
branch
2 times, most recently
from
f09648c to
9d3ea4b
Compare
added 2 commits
September 14, 2022 23:05
Francesco Capponi (FreCap)
force-pushed
the
avoid-deadlock-merge-requests-order
branch
2 times, most recently
from
ec48eb7 to
fb7a5c7
Compare
added 3 commits
September 15, 2022 13:24
* Avoid deadlock for wrong ordering execution of merge queries. The existing code implies that the executor will always run the queries in order, but this is not a hard guarantee of the executor. This can cause newer merge batches getting in front of merge batches, and locking the thread, which causes a deadlock Co-authored-by: fcapponi <francesco.capponi@worldquant.com>
* Avoid deadlock for wrong ordering execution of merge queries. The existing code implies that the executor will always run the queries in order, but this is not a hard guarantee of the executor. This can cause newer merge batches getting in front of merge batches, and locking the thread, which causes a deadlock Co-authored-by: fcapponi <francesco.capponi@worldquant.com>
Author
|
I've completed this MR locally, happy to share it if anyone interested (it needs some work since my branch is diverting a little bit) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is an exception within the executor, and one step could not be completed, will cause deadlock.
Even if there are way more topics than threads (like 5000 topics, 10 threads), chances are that there could be an ordering problem, and cause a deadlock (experiencing constantly)